Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2191)

Unified Diff: content/renderer/render_view_impl.cc

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/speech_recognition_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index d2bd98cfc27ad8a843cd5a0457b43f96566f66f5..dace92f09d5ca5824dbfc17a89363e4a0ffbbe38 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -99,7 +99,6 @@
#include "content/renderer/resizing_mode_selector.h"
#include "content/renderer/savable_resources.h"
#include "content/renderer/skia_benchmarking_extension.h"
-#include "content/renderer/speech_recognition_dispatcher.h"
#include "content/renderer/stats_collection_controller.h"
#include "content/renderer/stats_collection_observer.h"
#include "content/renderer/text_input_client_observer.h"
@@ -653,7 +652,6 @@ RenderViewImpl::RenderViewImpl(const ViewMsg_New_Params& params)
top_controls_constraints_(cc::BOTH),
#endif
has_scrolled_focused_editable_node_into_rect_(false),
- speech_recognition_dispatcher_(NULL),
devtools_agent_(NULL),
mouse_lock_dispatcher_(NULL),
#if defined(OS_ANDROID)
@@ -3410,8 +3408,6 @@ void RenderViewImpl::OnWasHidden() {
#if defined(OS_ANDROID) && defined(ENABLE_WEBRTC)
RenderThreadImpl::current()->video_capture_impl_manager()->
SuspendDevices(true);
- if (speech_recognition_dispatcher_)
- speech_recognition_dispatcher_->AbortAllRecognitions();
#endif
if (webview())
@@ -3758,12 +3754,6 @@ bool RenderViewImpl::ScheduleFileChooser(
return true;
}
-blink::WebSpeechRecognizer* RenderViewImpl::speechRecognizer() {
- if (!speech_recognition_dispatcher_)
- speech_recognition_dispatcher_ = new SpeechRecognitionDispatcher(this);
- return speech_recognition_dispatcher_;
-}
-
void RenderViewImpl::zoomLimitsChanged(double minimum_level,
double maximum_level) {
int minimum_percent = static_cast<int>(
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/speech_recognition_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698