extensions/shell/browser/shell_speech_recognition_manager_delegate.h - Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_speech_recognition_manager_delegate.h

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/shell/renderer/test_runner/web_test_proxy.cc ('k') | extensions/shell/browser/shell_speech_recognition_manager_delegate.cc » ('j') | extensions/shell/browser/shell_speech_recognition_manager_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/shell_speech_recognition_manager_delegate.h

diff --git a/extensions/shell/browser/shell_speech_recognition_manager_delegate.h b/extensions/shell/browser/shell_speech_recognition_manager_delegate.h

index 3a040b119e3481545c05fe029218b22bac443494..638f52f2bdf050f23f361ec9b6eb8f5c71b60db3 100644

--- a/extensions/shell/browser/shell_speech_recognition_manager_delegate.h

+++ b/extensions/shell/browser/shell_speech_recognition_manager_delegate.h

@@ -49,7 +49,7 @@ class ShellSpeechRecognitionManagerDelegate

static void CheckRenderViewType(

base::Callback<void(bool ask_user, bool is_allowed)> callback,

int render_process_id,

- int render_view_id);

+ int render_frame_id);

DISALLOW_COPY_AND_ASSIGN(ShellSpeechRecognitionManagerDelegate);

};