content/shell/renderer/test_runner/web_test_proxy.h - Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.h

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/shell/renderer/test_runner/web_frame_test_proxy.h ('k') | content/shell/renderer/test_runner/web_test_proxy.cc » ('j') | extensions/shell/browser/shell_speech_recognition_manager_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/web_test_proxy.h

diff --git a/content/shell/renderer/test_runner/web_test_proxy.h b/content/shell/renderer/test_runner/web_test_proxy.h

index 0cd6622a119ceb95a817fa452abc732cc3a5bd3f..5b854bea5ce0e7308c5bc1081f76b44886b9a4cc 100644

--- a/content/shell/renderer/test_runner/web_test_proxy.h

+++ b/content/shell/renderer/test_runner/web_test_proxy.h

@@ -173,7 +173,6 @@ class WebTestProxyBase {

blink::WebUserMediaClient* GetUserMediaClient();

void PrintPage(blink::WebLocalFrame* frame);

blink::WebMIDIClient* GetWebMIDIClient();

- blink::WebSpeechRecognizer* GetSpeechRecognizer();

bool RequestPointerLock();

void RequestPointerUnlock();

bool IsPointerLocked();

@@ -349,9 +348,6 @@ class WebTestProxy : public Base, public WebTestProxyBase {

virtual void printPage(blink::WebLocalFrame* frame) {

WebTestProxyBase::PrintPage(frame);

}

- virtual blink::WebSpeechRecognizer* speechRecognizer() {

- return WebTestProxyBase::GetSpeechRecognizer();

- }

virtual bool requestPointerLock() {

return WebTestProxyBase::RequestPointerLock();

}