content/renderer/render_view_impl.h - Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | extensions/shell/browser/shell_speech_recognition_manager_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index c6eb3642eb2bb41115370f764a7597f682998213..1d0a9d4f674081a7cdb93ca154b5a633135ed1a2 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -136,7 +136,6 @@ class RenderViewObserver;

class RenderViewTest;

class RendererDateTimePicker;

class RendererWebColorChooserImpl;

-class SpeechRecognitionDispatcher;

class WebPluginDelegateProxy;

struct DropData;

struct FaviconURL;

@@ -404,7 +403,6 @@ class CONTENT_EXPORT RenderViewImpl

virtual void navigateBackForwardSoon(int offset);

virtual int historyBackListCount();

virtual int historyForwardListCount();

- virtual blink::WebSpeechRecognizer* speechRecognizer();

virtual void zoomLimitsChanged(double minimum_level, double maximum_level);

virtual void zoomLevelChanged();

virtual double zoomLevelToZoomFactor(double zoom_level) const;

@@ -973,10 +971,6 @@ class CONTENT_EXPORT RenderViewImpl

// along with the RenderView automatically. This is why we just store

// weak references.

- // The speech recognition dispatcher attached to this view, lazily

- // initialized.

- SpeechRecognitionDispatcher* speech_recognition_dispatcher_;

// BrowserPluginManager attached to this view; lazily initialized.

scoped_refptr<BrowserPluginManager> browser_plugin_manager_;