content/renderer/render_frame_impl.h - Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/public/test/fake_speech_recognition_manager.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | extensions/shell/browser/shell_speech_recognition_manager_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 7be406d6a12a5ee369caef0f8b5a8cf2bbd12874..f7ccebe337e60e6957447389cc57ce92b850b30d 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -86,6 +86,7 @@ class RenderViewImpl;

class RenderWidget;

class RenderWidgetFullscreenPepper;

class ScreenOrientationDispatcher;

+class SpeechRecognitionDispatcher;

class UserMediaClientImpl;

struct CommitNavigationParams;

struct CommonNavigationParams;

@@ -477,6 +478,7 @@ class CONTENT_EXPORT RenderFrameImpl

const blink::WebAXObject& end_object,

int end_offset);

virtual void didChangeManifest(blink::WebLocalFrame*);

+ virtual blink::WebSpeechRecognizer* speechRecognizer();

// WebMediaPlayerDelegate implementation:

void DidPlay(blink::WebMediaPlayer* player) override;

@@ -802,6 +804,10 @@ class CONTENT_EXPORT RenderFrameImpl

// process.

ManifestManager* manifest_manager_;

+ // The speech recognition dispatcher attached to this frame, lazily

+ // initialized.

+ SpeechRecognitionDispatcher* speech_recognition_dispatcher_;

// The current accessibility mode.

AccessibilityMode accessibility_mode_;