Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes threading issues Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 #include "content/renderer/push_messaging_dispatcher.h" 83 #include "content/renderer/push_messaging_dispatcher.h"
84 #include "content/renderer/render_frame_proxy.h" 84 #include "content/renderer/render_frame_proxy.h"
85 #include "content/renderer/render_process.h" 85 #include "content/renderer/render_process.h"
86 #include "content/renderer/render_thread_impl.h" 86 #include "content/renderer/render_thread_impl.h"
87 #include "content/renderer/render_view_impl.h" 87 #include "content/renderer/render_view_impl.h"
88 #include "content/renderer/render_widget_fullscreen_pepper.h" 88 #include "content/renderer/render_widget_fullscreen_pepper.h"
89 #include "content/renderer/renderer_webapplicationcachehost_impl.h" 89 #include "content/renderer/renderer_webapplicationcachehost_impl.h"
90 #include "content/renderer/renderer_webcolorchooser_impl.h" 90 #include "content/renderer/renderer_webcolorchooser_impl.h"
91 #include "content/renderer/screen_orientation/screen_orientation_dispatcher.h" 91 #include "content/renderer/screen_orientation/screen_orientation_dispatcher.h"
92 #include "content/renderer/shared_worker_repository.h" 92 #include "content/renderer/shared_worker_repository.h"
93 #include "content/renderer/speech_recognition_dispatcher.h"
93 #include "content/renderer/v8_value_converter_impl.h" 94 #include "content/renderer/v8_value_converter_impl.h"
94 #include "content/renderer/websharedworker_proxy.h" 95 #include "content/renderer/websharedworker_proxy.h"
95 #include "gin/modules/module_registry.h" 96 #include "gin/modules/module_registry.h"
96 #include "media/base/audio_renderer_mixer_input.h" 97 #include "media/base/audio_renderer_mixer_input.h"
97 #include "media/base/renderer.h" 98 #include "media/base/renderer.h"
98 #include "media/blink/encrypted_media_player_support.h" 99 #include "media/blink/encrypted_media_player_support.h"
99 #include "media/blink/webcontentdecryptionmodule_impl.h" 100 #include "media/blink/webcontentdecryptionmodule_impl.h"
100 #include "media/blink/webmediaplayer_impl.h" 101 #include "media/blink/webmediaplayer_impl.h"
101 #include "media/blink/webmediaplayer_params.h" 102 #include "media/blink/webmediaplayer_params.h"
102 #include "media/filters/gpu_video_accelerator_factories.h" 103 #include "media/filters/gpu_video_accelerator_factories.h"
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 #if defined(ENABLE_BROWSER_CDMS) 580 #if defined(ENABLE_BROWSER_CDMS)
580 cdm_manager_(NULL), 581 cdm_manager_(NULL),
581 #endif 582 #endif
582 #if defined(VIDEO_HOLE) 583 #if defined(VIDEO_HOLE)
583 contains_media_player_(false), 584 contains_media_player_(false),
584 #endif 585 #endif
585 geolocation_dispatcher_(NULL), 586 geolocation_dispatcher_(NULL),
586 push_messaging_dispatcher_(NULL), 587 push_messaging_dispatcher_(NULL),
587 screen_orientation_dispatcher_(NULL), 588 screen_orientation_dispatcher_(NULL),
588 manifest_manager_(NULL), 589 manifest_manager_(NULL),
590 speech_recognition_dispatcher_(NULL),
589 accessibility_mode_(AccessibilityModeOff), 591 accessibility_mode_(AccessibilityModeOff),
590 renderer_accessibility_(NULL), 592 renderer_accessibility_(NULL),
591 weak_factory_(this) { 593 weak_factory_(this) {
592 std::pair<RoutingIDFrameMap::iterator, bool> result = 594 std::pair<RoutingIDFrameMap::iterator, bool> result =
593 g_routing_id_frame_map.Get().insert(std::make_pair(routing_id_, this)); 595 g_routing_id_frame_map.Get().insert(std::make_pair(routing_id_, this));
594 CHECK(result.second) << "Inserting a duplicate item."; 596 CHECK(result.second) << "Inserting a duplicate item.";
595 597
596 RenderThread::Get()->AddRoute(routing_id_, this); 598 RenderThread::Get()->AddRoute(routing_id_, this);
597 599
598 render_view_->RegisterRenderFrame(this); 600 render_view_->RegisterRenderFrame(this);
(...skipping 2784 matching lines...) Expand 10 before | Expand all | Expand 10 after
3383 } 3385 }
3384 } 3386 }
3385 3387
3386 void RenderFrameImpl::didChangeManifest(blink::WebLocalFrame* frame) 3388 void RenderFrameImpl::didChangeManifest(blink::WebLocalFrame* frame)
3387 { 3389 {
3388 DCHECK(!frame_ || frame_ == frame); 3390 DCHECK(!frame_ || frame_ == frame);
3389 3391
3390 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeManifest()); 3392 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeManifest());
3391 } 3393 }
3392 3394
3395 blink::WebSpeechRecognizer* RenderFrameImpl::speechRecognizer() {
3396 if (!speech_recognition_dispatcher_)
3397 speech_recognition_dispatcher_ = new SpeechRecognitionDispatcher(this);
3398 return speech_recognition_dispatcher_;
3399 }
3400
3393 void RenderFrameImpl::DidPlay(blink::WebMediaPlayer* player) { 3401 void RenderFrameImpl::DidPlay(blink::WebMediaPlayer* player) {
3394 Send(new FrameHostMsg_MediaPlayingNotification( 3402 Send(new FrameHostMsg_MediaPlayingNotification(
3395 routing_id_, reinterpret_cast<int64>(player), player->hasVideo(), 3403 routing_id_, reinterpret_cast<int64>(player), player->hasVideo(),
3396 player->hasAudio(), player->isRemote())); 3404 player->hasAudio(), player->isRemote()));
3397 } 3405 }
3398 3406
3399 void RenderFrameImpl::DidPause(blink::WebMediaPlayer* player) { 3407 void RenderFrameImpl::DidPause(blink::WebMediaPlayer* player) {
3400 Send(new FrameHostMsg_MediaPausedNotification( 3408 Send(new FrameHostMsg_MediaPausedNotification(
3401 routing_id_, reinterpret_cast<int64>(player))); 3409 routing_id_, reinterpret_cast<int64>(player)));
3402 } 3410 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
3450 InternalDocumentStateData::FromDocumentState(document_state); 3458 InternalDocumentStateData::FromDocumentState(document_state);
3451 3459
3452 FrameHostMsg_DidCommitProvisionalLoad_Params params; 3460 FrameHostMsg_DidCommitProvisionalLoad_Params params;
3453 params.http_status_code = response.httpStatusCode(); 3461 params.http_status_code = response.httpStatusCode();
3454 params.url_is_unreachable = ds->hasUnreachableURL(); 3462 params.url_is_unreachable = ds->hasUnreachableURL();
3455 params.is_post = false; 3463 params.is_post = false;
3456 params.post_id = -1; 3464 params.post_id = -1;
3457 params.page_id = render_view_->page_id_; 3465 params.page_id = render_view_->page_id_;
3458 // We need to track the RenderViewHost routing_id because of downstream 3466 // We need to track the RenderViewHost routing_id because of downstream
3459 // dependencies (crbug.com/392171 DownloadRequestHandle, SaveFileManager, 3467 // dependencies (crbug.com/392171 DownloadRequestHandle, SaveFileManager,
3460 // ResourceDispatcherHostImpl, MediaStreamUIProxy, 3468 // ResourceDispatcherHostImpl, MediaStreamUIProxy, and possibly others). They
3461 // SpeechRecognitionDispatcherHost and possibly others). They look up the view 3469 // look up the view based on the ID stored in the resource requests. Once
3462 // based on the ID stored in the resource requests. Once those dependencies 3470 // those dependencies are unwound or moved to RenderFrameHost
3463 // are unwound or moved to RenderFrameHost (crbug.com/304341) we can move the 3471 // (crbug.com/304341) we can move the client to be based on the routing_id of
3464 // client to be based on the routing_id of the RenderFrameHost. 3472 // the RenderFrameHost.
3465 params.render_view_routing_id = render_view_->routing_id(); 3473 params.render_view_routing_id = render_view_->routing_id();
3466 params.socket_address.set_host(response.remoteIPAddress().utf8()); 3474 params.socket_address.set_host(response.remoteIPAddress().utf8());
3467 params.socket_address.set_port(response.remotePort()); 3475 params.socket_address.set_port(response.remotePort());
3468 WebURLResponseExtraDataImpl* extra_data = GetExtraDataFromResponse(response); 3476 WebURLResponseExtraDataImpl* extra_data = GetExtraDataFromResponse(response);
3469 if (extra_data) 3477 if (extra_data)
3470 params.was_fetched_via_proxy = extra_data->was_fetched_via_proxy(); 3478 params.was_fetched_via_proxy = extra_data->was_fetched_via_proxy();
3471 params.was_within_same_page = navigation_state->was_within_same_page(); 3479 params.was_within_same_page = navigation_state->was_within_same_page();
3472 params.security_info = response.securityInfo(); 3480 params.security_info = response.securityInfo();
3473 3481
3474 // Set the URL to be displayed in the browser UI to the user. 3482 // Set the URL to be displayed in the browser UI to the user.
(...skipping 757 matching lines...) Expand 10 before | Expand all | Expand 10 after
4232 4240
4233 #if defined(ENABLE_BROWSER_CDMS) 4241 #if defined(ENABLE_BROWSER_CDMS)
4234 RendererCdmManager* RenderFrameImpl::GetCdmManager() { 4242 RendererCdmManager* RenderFrameImpl::GetCdmManager() {
4235 if (!cdm_manager_) 4243 if (!cdm_manager_)
4236 cdm_manager_ = new RendererCdmManager(this); 4244 cdm_manager_ = new RendererCdmManager(this);
4237 return cdm_manager_; 4245 return cdm_manager_;
4238 } 4246 }
4239 #endif // defined(ENABLE_BROWSER_CDMS) 4247 #endif // defined(ENABLE_BROWSER_CDMS)
4240 4248
4241 } // namespace content 4249 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698