Source/web/WebViewImpl.cpp - Issue 636863002: Make SpeechRecognitionController per frame instead of per page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 636863002: Make SpeechRecognitionController per frame instead of per page. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index d002f3e658c7938c78fc23dd505c927885655d79..c85f7009eb31df1ad0af3bef5a6fa0916d6a404d 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -147,7 +147,6 @@

#include "web/NavigatorContentUtilsClientImpl.h"

#include "web/PopupContainer.h"

#include "web/PrerendererClientImpl.h"

-#include "web/SpeechRecognitionClientProxy.h"

#include "web/StorageQuotaClientImpl.h"

#include "web/ValidationMessageClientImpl.h"

#include "web/ViewportAnchor.h"

@@ -431,7 +430,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client)

m_page = adoptPtrWillBeNoop(new Page(pageClients));

MediaKeysController::provideMediaKeysTo(*m_page, &m_mediaKeysClientImpl);

- provideSpeechRecognitionTo(*m_page, SpeechRecognitionClientProxy::create(client ? client->speechRecognizer() : 0));

provideNavigatorContentUtilsTo(*m_page, NavigatorContentUtilsClientImpl::create(this));

provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create());

« Source/web/WebLocalFrameImpl.cpp ('K') | « Source/web/WebLocalFrameImpl.cpp ('k') | public/web/WebFrameClient.h » ('j') | public/web/WebViewClient.h » ('J')