Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: Source/modules/speech/SpeechRecognitionController.h

Issue 636863002: Make SpeechRecognitionController per frame instead of per page. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/speech/SpeechRecognitionController.h
diff --git a/Source/modules/speech/SpeechRecognitionController.h b/Source/modules/speech/SpeechRecognitionController.h
index b04c9a7b42e17fce7379663663adc0b797f5230e..21883c865031ab9c0554d37ab67ca67fb00eea0a 100644
--- a/Source/modules/speech/SpeechRecognitionController.h
+++ b/Source/modules/speech/SpeechRecognitionController.h
@@ -34,7 +34,9 @@ namespace blink {
class MediaStreamTrack;
-class SpeechRecognitionController final : public NoBaseWillBeGarbageCollectedFinalized<SpeechRecognitionController>, public WillBeHeapSupplement<Page> {
+class SpeechRecognitionController final
+ : public NoBaseWillBeGarbageCollectedFinalized<SpeechRecognitionController>,
+ public WillBeHeapSupplement<LocalFrame> {
dcheng 2014/11/11 08:09:58 Alignment. I think git cl format mostly handles Bl
mlamouri (slow - plz ping) 2014/11/28 10:43:04 Done.
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechRecognitionController);
public:
virtual ~SpeechRecognitionController();
@@ -47,11 +49,11 @@ public:
void stop(SpeechRecognition* recognition) { m_client->stop(recognition); }
void abort(SpeechRecognition* recognition) { m_client->abort(recognition); }
- static PassOwnPtrWillBeRawPtr<SpeechRecognitionController> create(PassOwnPtr<SpeechRecognitionClient>);
static const char* supplementName();
- static SpeechRecognitionController* from(Page* page) { return static_cast<SpeechRecognitionController*>(WillBeHeapSupplement<Page>::from(page, supplementName())); }
+ static void provideTo(LocalFrame&, PassOwnPtr<SpeechRecognitionClient>);
+ static SpeechRecognitionController* from(LocalFrame&);
- virtual void trace(Visitor* visitor) override { WillBeHeapSupplement<Page>::trace(visitor); }
+ void trace(Visitor*) override;
private:
explicit SpeechRecognitionController(PassOwnPtr<SpeechRecognitionClient>);

Powered by Google App Engine
This is Rietveld 408576698