Source/modules/speech/SpeechRecognition.cpp - Issue 636863002: Make SpeechRecognitionController per frame instead of per page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechRecognition.cpp

Issue 636863002: Make SpeechRecognitionController per frame instead of per page. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/speech/SpeechRecognition.cpp

diff --git a/Source/modules/speech/SpeechRecognition.cpp b/Source/modules/speech/SpeechRecognition.cpp

index 16d59af59a4ab2b0494dc03378537b5f4fdb0121..e641b5619f7612b2e56713d80f203488d89e8ed3 100644

--- a/Source/modules/speech/SpeechRecognition.cpp

+++ b/Source/modules/speech/SpeechRecognition.cpp

@@ -180,10 +180,10 @@ SpeechRecognition::SpeechRecognition(ExecutionContext* context)

{

Document* document = toDocument(executionContext());

- Page* page = document->page();

- ASSERT(page);

+ LocalFrame* frame = document->frame();

+ ASSERT(frame);

- m_controller = SpeechRecognitionController::from(page);

+ m_controller = SpeechRecognitionController::from(*frame);

ASSERT(m_controller);

// FIXME: Need to hook up with Page to get notified when the visibility changes.

« no previous file with comments | « no previous file | Source/modules/speech/SpeechRecognitionController.h » ('j') | Source/modules/speech/SpeechRecognitionController.h » ('J')