Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 636833002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/events (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/events This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -146 lines) Patch
M Source/core/events/AnimationPlayerEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/ApplicationCacheErrorEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/AutocompleteErrorEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/BeforeTextInsertedEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/BeforeUnloadEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/ClipboardEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/CompositionEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/CustomEvent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/DOMWindowEventQueue.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/events/ErrorEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/EventFactory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/EventPath.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTarget.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/FocusEvent.h View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/events/GenericEventQueue.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/events/GestureEvent.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/HashChangeEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/KeyboardEvent.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/events/MessageEvent.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/MouseEvent.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/events/MouseRelatedEvent.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/MutationEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/OverflowEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/PageTransitionEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/PopStateEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/ProgressEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/RelatedEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/ResourceProgressEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/SecurityPolicyViolationEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/TextEvent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/TouchEvent.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/events/TransitionEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/TreeScopeEventContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/UIEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/WebKitAnimationEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/WheelEvent.h View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:07:55 UTC) #2
Mike West
rs lgtm.
6 years, 2 months ago (2014-10-07 12:55:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636833002/1
6 years, 2 months ago (2014-10-07 13:00:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:48:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183330

Powered by Google App Engine
This is Rietveld 408576698