Merge 77597 - 2011-02-03 Anton Muhin <antonm@chromium.org>...

Source/WebCore/bindings/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 394 matching lines @@
     if (object->IsInt32())
         return int32ToWebCoreString(object->Int32Value());
 
     v8::TryCatch block;
     v8::Handle<v8::String> v8String = object->ToString();
     // Handle the case where an exception is thrown as part of invoking toString on the object.
     if (block.HasCaught()) {
         throwError(block.Exception());
         return StringImpl::empty();
     }
+    // This path is unexpected.  However there is hypothesis that it
+    // might be combination of v8 and v8 bindings bugs.  For now
+    // just bailout as we'll crash if attempt to convert empty handle into a string.
+    if (v8String.IsEmpty()) {
+        ASSERT_NOT_REACHED();
+        return StringImpl::empty();
+    }
     return v8StringToWebCoreString<String>(v8String, DoNotExternalize);
 }
 
 AtomicString v8NonStringValueToAtomicWebCoreString(v8::Handle<v8::Value> object)
 {
     ASSERT(!object->IsString());
     return AtomicString(v8NonStringValueToWebCoreString(object));
 }
 
 static bool stringImplCacheEnabled = false;
@@ skipping 147 matching lines @@
 void setElementStringAttr(const v8::AccessorInfo& info,
                           const QualifiedName& name,
                           v8::Local<v8::Value> value)
 {
     Element* imp = V8Element::toNative(info.Holder());
     AtomicString v = toAtomicWebCoreStringWithNullCheck(value);
     imp->setAttribute(name, v);
 }
 
 } // namespace WebCore