Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 77826) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,872 +1,24 @@ |
-2011-02-04 Charlie Reis <creis@chromium.org> |
- |
- Reviewed by Mihai Parparita. |
- |
- Crash in WebCore::HistoryController::itemsAreClones |
- https://bugs.webkit.org/show_bug.cgi?id=52819 |
- |
- Avoids deleting the current HistoryItem while it is still in use. |
- Ensures that provisional items are committed for same document navigations. |
- Ensures that error pages are committed on back/forward navigations. |
- Also removes unneeded sanity checks used for diagnosing the problem. |
- |
- * loader/HistoryController.cpp: |
- * loader/HistoryController.h: |
- |
-2011-02-04 Carol Szabo <carol.szabo@nokia.com> |
- |
- Reviewed by David Hyatt. |
- |
- Code Changes. |
- |
- CSS 2.1 failure: content-* |
- https://bugs.webkit.org/show_bug.cgi?id=52126 |
- |
- Test: fast/css/counters/content-021.html |
- |
- * rendering/CounterNode.cpp: |
- (showCounterTree): |
- Made parameter const because it is supposed to be so. |
- * rendering/RenderCounter.cpp: |
- (WebCore::previousInPreOrder): |
- (WebCore::previousSiblingOrParent): |
- (WebCore::parentElement): |
- (WebCore::areRenderersElementsSiblings): |
- (WebCore::nextInPreOrder): |
- Added these local helper functions to help navigate the DOM tree |
- enriched with :before and :after pseudo elements. |
- (WebCore::planCounter): |
- Fixed bug that would create a repeat counter for second and |
- subsequent renderers associated with the same DOM element. |
- (WebCore::findPlaceForCounter): |
- (WebCore::makeCounterNode): |
- Changed to use the new tree navigation functions described above |
- instead of the Renderer Tree navigation functions. |
- (WebCore::RenderCounter::rendererSubtreeAttached): |
- (WebCore::RenderCounter::rendererStyleChanged): |
- Optimized to not bother about counters until the renderers are |
- finally attached. |
- (showRendererTree): |
- (showNodeTree): |
- Debug helper functions used to debug Counter bugs. |
- |
-2011-02-04 Dan Bernstein <mitz@apple.com> |
- |
- Typo fix. |
- |
- * html/parser/XSSFilter.cpp: |
- (WebCore::HTMLNames::containsJavaScriptURL): |
- |
-2011-02-04 Dan Bernstein <mitz@apple.com> |
- |
- Reviewed by Anders Carlsson. |
- |
- Make an infinite loop introduced in r77454 finite. |
- |
- * html/parser/XSSFilter.cpp: |
- (WebCore::HTMLNames::containsJavaScriptURL): |
- |
-2011-02-04 Jer Noble <jer.noble@apple.com> |
- |
- Reviewed by Eric Carlson. |
- |
- Frame accurate seeking isn't always accurate |
- https://bugs.webkit.org/show_bug.cgi?id=52697 |
- |
- Test: media/video-frame-accurate-seek.html |
- |
- Make seeking slightly more accurate by rounding instead of truncating |
- when converting from seconds-in-float to time/timeScale. |
- |
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: |
- (WebCore::MediaPlayerPrivateQTKit::createQTTime): |
- * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: |
- (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): |
- * platform/graphics/win/QTMovie.cpp: |
- (QTMovie::setCurrentTime): |
- |
-2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
- |
- Reviewed by Nate Chapin. |
- |
- Second IndexedDB events overhaul patch |
- https://bugs.webkit.org/show_bug.cgi?id=53813 |
- |
- If an IDBRequest has a IDBTransaction, it should propogate |
- events through it. In order to do this, IDBRequest needs to |
- hold a transaction frontend object rather than a backend one. |
- |
- Test: storage/indexeddb/request-event-propagation.html |
- |
- * storage/IDBCursor.cpp: |
- (WebCore::IDBCursor::IDBCursor): |
- * storage/IDBCursor.h: |
- (WebCore::IDBCursor::create): |
- * storage/IDBDatabase.cpp: |
- (WebCore::IDBDatabase::setSetVersionTransaction): |
- (WebCore::IDBDatabase::createObjectStore): |
- (WebCore::IDBDatabase::deleteObjectStore): |
- * storage/IDBDatabase.h: |
- * storage/IDBIndex.cpp: |
- (WebCore::IDBIndex::IDBIndex): |
- (WebCore::IDBIndex::openCursor): |
- (WebCore::IDBIndex::openKeyCursor): |
- (WebCore::IDBIndex::get): |
- (WebCore::IDBIndex::getKey): |
- * storage/IDBIndex.h: |
- (WebCore::IDBIndex::create): |
- * storage/IDBObjectStore.cpp: |
- (WebCore::IDBObjectStore::IDBObjectStore): |
- (WebCore::IDBObjectStore::get): |
- (WebCore::IDBObjectStore::add): |
- (WebCore::IDBObjectStore::put): |
- (WebCore::IDBObjectStore::deleteFunction): |
- (WebCore::IDBObjectStore::createIndex): |
- (WebCore::IDBObjectStore::deleteIndex): |
- (WebCore::IDBObjectStore::openCursor): |
- * storage/IDBObjectStore.h: |
- (WebCore::IDBObjectStore::create): |
- * storage/IDBRequest.cpp: |
- (WebCore::IDBRequest::create): |
- (WebCore::IDBRequest::IDBRequest): |
- (WebCore::IDBRequest::resetReadyState): |
- (WebCore::IDBRequest::onSuccess): |
- (WebCore::IDBRequest::dispatchEvent): |
- * storage/IDBRequest.h: |
- * storage/IDBTransaction.cpp: |
- (WebCore::IDBTransaction::IDBTransaction): |
- (WebCore::IDBTransaction::objectStore): |
- (WebCore::IDBTransaction::contextDestroyed): |
- (WebCore::IDBTransaction::enqueueEvent): |
- * storage/IDBTransaction.h: |
- * storage/IDBTransaction.idl: |
- |
-2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
- |
- Reviewed by Nate Chapin. |
- |
- First step towards event propogation within IndexedDB |
- https://bugs.webkit.org/show_bug.cgi?id=53795 |
- |
- This is the first step towards implementing |
- http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348 |
- within IndexedDB. I've created a method that knows how |
- to capture and bubble (based on Node's dispatchGenericEvent). |
- I've then changed IDBRequest to use it. |
- |
- The only functional change is that preventDefault now must |
- be called in error events to prevent the transaction from |
- being aborted. The tests reflect this change and there's one |
- specific test to look at this behavior. |
- |
- Test: storage/indexeddb/error-causes-abort-by-default.html |
- |
- * storage/IDBAbortEvent.cpp: |
- (WebCore::IDBAbortEvent::create): |
- (WebCore::IDBAbortEvent::IDBAbortEvent): |
- * storage/IDBAbortEvent.h: |
- * storage/IDBCompleteEvent.cpp: |
- (WebCore::IDBCompleteEvent::create): |
- (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
- * storage/IDBCompleteEvent.h: |
- * storage/IDBErrorEvent.cpp: |
- (WebCore::IDBErrorEvent::IDBErrorEvent): |
- * storage/IDBEvent.cpp: |
- (WebCore::IDBEvent::IDBEvent): |
- (WebCore::IDBEvent::dispatch): |
- * storage/IDBEvent.h: |
- * storage/IDBRequest.cpp: |
- (WebCore::IDBRequest::dispatchEvent): |
- * storage/IDBRequest.h: |
- * storage/IDBSuccessEvent.cpp: |
- (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
- * storage/IDBTransaction.cpp: |
- (WebCore::IDBTransaction::onAbort): |
- (WebCore::IDBTransaction::onComplete): |
- * storage/IDBTransaction.h: |
- (WebCore::IDBTransaction::backend): |
- * storage/IDBTransactionBackendImpl.cpp: |
- (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
- |
-2011-02-04 Daniel Cheng <dcheng@chromium.org> |
- |
- Reviewed by Dmitry Titov. |
- |
- Clone WebClipboard to be frame-specific. |
- https://bugs.webkit.org/show_bug.cgi?id=53727 |
- |
- For drop operations, Chrome currently snapshots the data and copies it |
- into the renderer process. As we add more supported drag data types, the |
- copy will become increasingly expensive. Instead, we'd like to snapshot |
- data in the browser to reduce the amount of data copied and to support |
- Blob in DataTransferItem. In order to allow this, we associated |
- WebClipboard with a frame so it can correctly route its IPCs to the |
- corresponding Chromium host. |
- |
- No new tests because no new functionality. |
- |
- * platform/chromium/ChromiumDataObject.cpp: |
- (WebCore::ChromiumDataObject::createReadable): |
- * platform/chromium/ChromiumDataObject.h: |
- * platform/chromium/ClipboardChromium.cpp: |
- (WebCore::ClipboardChromium::create): |
- * platform/chromium/PlatformBridge.h: |
- * platform/chromium/ReadableDataObject.cpp: |
- (WebCore::ReadableDataObject::create): |
- (WebCore::ReadableDataObject::ReadableDataObject): |
- (WebCore::ReadableDataObject::getData): |
- (WebCore::ReadableDataObject::urlTitle): |
- (WebCore::ReadableDataObject::htmlBaseUrl): |
- (WebCore::ReadableDataObject::filenames): |
- (WebCore::ReadableDataObject::ensureTypeCacheInitialized): |
- * platform/chromium/ReadableDataObject.h: |
- |
-2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
- |
- Revert https://bugs.webkit.org/show_bug.cgi?id=53795 |
- |
- * storage/IDBAbortEvent.cpp: |
- (WebCore::IDBAbortEvent::create): |
- (WebCore::IDBAbortEvent::IDBAbortEvent): |
- * storage/IDBAbortEvent.h: |
- * storage/IDBCompleteEvent.cpp: |
- (WebCore::IDBCompleteEvent::create): |
- (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
- * storage/IDBCompleteEvent.h: |
- * storage/IDBErrorEvent.cpp: |
- (WebCore::IDBErrorEvent::IDBErrorEvent): |
- * storage/IDBEvent.cpp: |
- (WebCore::IDBEvent::IDBEvent): |
- * storage/IDBEvent.h: |
- * storage/IDBRequest.cpp: |
- (WebCore::IDBRequest::dispatchEvent): |
- * storage/IDBRequest.h: |
- * storage/IDBSuccessEvent.cpp: |
- (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
- * storage/IDBTransaction.cpp: |
- (WebCore::IDBTransaction::onAbort): |
- (WebCore::IDBTransaction::onComplete): |
- * storage/IDBTransaction.h: |
- * storage/IDBTransactionBackendImpl.cpp: |
- (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
- |
-2011-02-04 Martin Galpin <martin@66laps.com> |
- |
- Reviewed by David Levin. |
- |
- CORS origin header not set on GET when a preflight request is required. |
- https://bugs.webkit.org/show_bug.cgi?id=50773 |
- |
- Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html |
- |
- * loader/DocumentThreadableLoader.cpp: |
- (WebCore::DocumentThreadableLoader::preflightSuccess): |
- Explicitly set the request origin after a preflight request succeeds. |
- |
-2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
- |
- Reviewed by Nate Chapin. |
- |
- First step towards event propogation within IndexedDB |
- https://bugs.webkit.org/show_bug.cgi?id=53795 |
- |
- This is the first step towards implementing |
- http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348 |
- within IndexedDB. I've created a method that knows how |
- to capture and bubble (based on Node's dispatchGenericEvent). |
- I've then changed IDBRequest to use it. |
- |
- The only functional change is that preventDefault now must |
- be called in error events to prevent the transaction from |
- being aborted. The tests reflect this change and there's one |
- specific test to look at this behavior. |
- |
- Test: storage/indexeddb/error-causes-abort-by-default.html |
- |
- * storage/IDBAbortEvent.cpp: |
- (WebCore::IDBAbortEvent::create): |
- (WebCore::IDBAbortEvent::IDBAbortEvent): |
- * storage/IDBAbortEvent.h: |
- * storage/IDBCompleteEvent.cpp: |
- (WebCore::IDBCompleteEvent::create): |
- (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
- * storage/IDBCompleteEvent.h: |
- * storage/IDBErrorEvent.cpp: |
- (WebCore::IDBErrorEvent::IDBErrorEvent): |
- * storage/IDBEvent.cpp: |
- (WebCore::IDBEvent::IDBEvent): |
- (WebCore::IDBEvent::dispatch): |
- * storage/IDBEvent.h: |
- * storage/IDBRequest.cpp: |
- (WebCore::IDBRequest::dispatchEvent): |
- * storage/IDBRequest.h: |
- * storage/IDBSuccessEvent.cpp: |
- (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
- * storage/IDBTransaction.cpp: |
- (WebCore::IDBTransaction::onAbort): |
- (WebCore::IDBTransaction::onComplete): |
- * storage/IDBTransaction.h: |
- (WebCore::IDBTransaction::backend): |
- * storage/IDBTransactionBackendImpl.cpp: |
- (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
- |
-2011-02-04 Dimitri Glazkov <dglazkov@chromium.org> |
- |
- Reviewed by Csaba Osztrogonác. |
- |
- [Qt]REGRESSION(r76951): media/controls-without-preload.html fails |
- https://bugs.webkit.org/show_bug.cgi?id=53674 |
- |
- * css/mediaControlsQt.css: |
- |
-2011-02-04 Dan Bernstein <mitz@apple.com> |
- |
- Reviewed by Darin Adler and Dave Hyatt. |
- |
- <rdar://problem/8902704> Make ruby text size 50% by default |
- https://bugs.webkit.org/show_bug.cgi?id=53723 |
- |
- * css/html.css: |
- (ruby > rt): Changed the font-size from 60% to 50%. |
- |
-2011-02-04 Antti Koivisto <antti@apple.com> |
- |
- Reviewed by Dimitri Glazkov. |
- |
- https://bugs.webkit.org/show_bug.cgi?id=53610 |
- Regression: adjacent sibling selector not working as expected |
- <rdar://problem/8960033> |
- |
- https://bugs.webkit.org/show_bug.cgi?id=53574 |
- REGRESSION (r76012): :last-child:after not working as expected |
- <rdar://problem/8948643> |
- |
- Test for additional conditions in parent style that prevent sharing. |
- |
- Tests: fast/selectors/style-sharing-adjacent-selector.html |
- fast/selectors/style-sharing-last-child.html |
- |
- * css/CSSStyleSelector.cpp: |
- (WebCore::parentStylePreventsSharing): |
- (WebCore::CSSStyleSelector::locateSharedStyle): |
- |
-2011-02-04 Mark Mentovai <mark@chromium.org> |
- |
- Reviewed by Dimitri Glazkov. |
- |
- Chromium GYP build fix. |
- |
- When various settings were moved to webcore_prerequisites in r66364, |
- things that should have been direct_dependent_settings were not marked |
- as such. GYP 'defines', for example, make no sense on a 'none'-type |
- target such as webcore_prerequisites. It appears that it was intended |
- for these settings to be pushed to direct dependents, which would make |
- direct_dependent_settings correct. |
- |
- Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused |
- http://crbug.com/71537, which at best causes Mac console log spew, and |
- at worst may result in Chromium's copy of WebCore using system |
- definitions of certain Objective-C classes at runtime, or vice-versa. |
- |
- The build now includes a postbuild step to prevent |
- http://crbug.com/71537 from regressing again. The build will fail upon |
- regression. |
- |
- https://bugs.webkit.org/show_bug.cgi?id=53630 |
- |
- * WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into |
- direct_dependent_settings as needed, add the check_objc_rename |
- postbuild step. |
- * WebCore.gyp/mac/check_objc_rename.sh: Added. |
- |
-2011-02-04 Robert Hogan <robert@webkit.org> |
- |
- Reviewed by Darin Fisher. |
- |
- Move chromium iframe shim code to cross-platform file |
- https://bugs.webkit.org/show_bug.cgi?id=52594 |
- |
- Move Chromium code for identifying and cutting out |
- iframe shims from plugins to cross-platform utility file |
- IFrameShimSupport.cpp. |
- Amend PluginViewQt to use this code to handle shims correctly. |
- |
- * WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp |
- * WebCore.pro: Add Qt support for IFrameShimSupport.cpp |
- * plugins/IFrameShimSupport.cpp: Added. |
- (WebCore::getObjectStack): |
- (WebCore::iframeIsAbovePlugin): |
- (WebCore::getPluginOcclusions): |
- * plugins/IFframeShimSupport.h: Added. |
- * plugins/qt/PluginViewQt.cpp: |
- (WebCore::PluginView::setNPWindowIfNeeded): |
- |
-2011-02-04 Xiaomei Ji <xji@chromium.org> |
- |
- Reviewed by David Levin. |
- |
- Implement "<option> should implement the dir attribute" for chromium port after r76983. |
- https://bugs.webkit.org/show_bug.cgi?id=50969 |
- |
- Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html |
- added in r76983. |
- |
- * platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from |
- <select> drop-down setting. |
- (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint |
- items in drop-down and pass-in bidi override flag when creating text run. |
- * platform/chromium/PopupMenuChromium.h: Remove directionalityHint from |
- PopupContainerSettings. |
- |
-2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
- |
- Build fix from merge mistake. |
- |
- * storage/IDBTransaction.cpp: |
- (WebCore::IDBTransaction::ensureEventTargetData): |
- |
-2011-02-04 Levi Weintraub <leviw@chromium.org> |
- |
- Reviewed by Darin Adler. |
- |
- Remove unneeded function declarations in comments in EditorClient.h |
- https://bugs.webkit.org/show_bug.cgi?id=53745 |
- |
- Removing unused commented out function declarations. No tests since this is just cleanup. |
- |
- * page/EditorClient.h: |
- |
-2011-02-03 Jeremy Orlow <jorlow@chromium.org> |
- |
- Reviewed by Nate Chapin. |
- |
- Refactor IDBRequest and IDBTransaction a bit |
- https://bugs.webkit.org/show_bug.cgi?id=53565 |
- |
- There were a lot of subtle issues with the way IDBTransaction |
- and IDBRequest used to be written. This cleans a lot of them up |
- and largely simplifies the logic. Using EventQueue rather than |
- timers is one example of the simplification. |
- |
- * bindings/scripts/CodeGeneratorV8.pm: |
- * dom/EventQueue.cpp: |
- (WebCore::EventQueue::enqueueEvent): |
- (WebCore::EventQueue::dispatchEvent): |
- * storage/IDBCursor.cpp: |
- (WebCore::IDBCursor::continueFunction): |
- * storage/IDBRequest.cpp: |
- (WebCore::IDBRequest::create): |
- (WebCore::IDBRequest::IDBRequest): |
- (WebCore::IDBRequest::resetReadyState): |
- (WebCore::IDBRequest::onError): |
- (WebCore::IDBRequest::onSuccess): |
- (WebCore::IDBRequest::dispatchEvent): |
- (WebCore::IDBRequest::enqueueEvent): |
- (WebCore::IDBRequest::eventTargetData): |
- (WebCore::IDBRequest::ensureEventTargetData): |
- * storage/IDBRequest.h: |
- (WebCore::IDBRequest::dispatchEvent): |
- * storage/IDBTransaction.cpp: |
- (WebCore::IDBTransaction::create): |
- (WebCore::IDBTransaction::IDBTransaction): |
- (WebCore::IDBTransaction::objectStore): |
- (WebCore::IDBTransaction::abort): |
- (WebCore::IDBTransaction::onAbort): |
- (WebCore::IDBTransaction::onComplete): |
- (WebCore::IDBTransaction::onTimeout): |
- (WebCore::IDBTransaction::canSuspend): |
- (WebCore::IDBTransaction::stop): |
- (WebCore::IDBTransaction::enqueueEvent): |
- (WebCore::IDBTransaction::eventTargetData): |
- (WebCore::IDBTransaction::ensureEventTargetData): |
- * storage/IDBTransaction.h: |
- |
-2011-02-01 Jeremy Orlow <jorlow@chromium.org> |
- |
- Reviewed by Nate Chapin. |
- |
- Remove the timeout event from IndexedDB |
- https://bugs.webkit.org/show_bug.cgi?id=53521 |
- |
- Remove timeout and ontimeout from IDBTransaction per the spec. |
- |
- * WebCore.gypi: |
- * storage/IDBDatabase.cpp: |
- (WebCore::IDBDatabase::transaction): |
- * storage/IDBDatabase.h: |
- (WebCore::IDBDatabase::transaction): |
- * storage/IDBDatabase.idl: |
- * storage/IDBDatabaseBackendImpl.cpp: |
- (WebCore::IDBDatabaseBackendImpl::setVersion): |
- (WebCore::IDBDatabaseBackendImpl::transaction): |
- * storage/IDBDatabaseBackendImpl.h: |
- * storage/IDBDatabaseBackendInterface.h: |
- * storage/IDBTimeoutEvent.cpp: Removed. |
- * storage/IDBTimeoutEvent.h: Removed. |
- * storage/IDBTransaction.cpp: |
- (WebCore::IDBTransaction::IDBTransaction): |
- (WebCore::IDBTransaction::onAbort): |
- (WebCore::IDBTransaction::onComplete): |
- * storage/IDBTransaction.h: |
- * storage/IDBTransaction.idl: |
- * storage/IDBTransactionBackendImpl.cpp: |
- (WebCore::IDBTransactionBackendImpl::create): |
- (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): |
- * storage/IDBTransactionBackendImpl.h: |
- * storage/IDBTransactionCallbacks.h: |
- |
-2011-02-04 Chris Fleizach <cfleizach@apple.com> |
- |
- Reviewed by Darin Adler. |
- |
- AX: Can't set accessibility overridden attributes on web objects |
- https://bugs.webkit.org/show_bug.cgi?id=53725 |
- |
- accessibilitySetOverriddenValue does not work on AX objects from WebCore because |
- the right method needed to be overridden (accessibilitySupportsOverriddenAttributes). |
- Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden |
- attribute only when an AX client asks for it through the AX frameworks. |
- |
- * accessibility/mac/AccessibilityObjectWrapper.mm: |
- (-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]): |
- |
-2011-02-03 Dimitri Glazkov <dglazkov@chromium.org> |
- |
- Reviewed by Kent Tamura. |
- |
- REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track. |
- https://bugs.webkit.org/show_bug.cgi?id=53691 |
- |
- Test: fast/repaint/slider-thumb-drag-release.html |
- |
- * html/shadow/SliderThumbElement.cpp: |
- (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure |
- that the thumb is repainted. |
- |
-2011-02-04 Mikhail Naganov <mnaganov@chromium.org> |
- |
- Reviewed by Pavel Feldman. |
- |
- Web Inspector: Add "show more" data grid node and waiting message UI components. |
- https://bugs.webkit.org/show_bug.cgi?id=53763 |
- |
- - "show more" data grid node is used for on-demand population of |
- data grid contents (similar to DOM tree capability for limiting |
- displayed nodes count); |
- |
- - waiting message is used for informing user about long lasting |
- operations (with a possibility to cancel them). |
- |
- * English.lproj/localizedStrings.js: |
- * WebCore.gypi: |
- * WebCore.vcproj/WebCore.vcproj: |
- * inspector/front-end/PleaseWaitMessage.js: Added. |
- (WebInspector.PleaseWaitMessage): |
- * inspector/front-end/ShowMoreDataGridNode.js: Added. |
- (WebInspector.ShowMoreDataGridNode): |
- * inspector/front-end/WebKit.qrc: |
- * inspector/front-end/inspector.css: |
- (.data-grid button): |
- (.please-wait-msg): |
- * inspector/front-end/inspector.html: |
- |
-2011-02-04 Adele Peterson <adele@apple.com> |
- |
- Reviewed by Dan Bernstein. |
- |
- Fix for https://bugs.webkit.org/show_bug.cgi?id=53740 |
- <rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused |
- |
- Tests: |
- fast/forms/textarea-placeholder-visibility-1.html |
- fast/forms/textarea-placeholder-visibility-2.html |
- fast/forms/input-placeholder-visibility-1.html |
- fast/forms/input-placeholder-visibility-2.html |
- fast/forms/input-placeholder-visibility-3.html |
- |
- * html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): |
- Add a check for shouldShowPlaceholderWhenFocused. |
- * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue): |
- Whenever the value is updated, we should also update placeholder visibility. |
- * rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused): |
- Make the default the same as the existing behavior. |
- * rendering/RenderThemeMac.h: |
- * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused): |
- Show placeholder when appropriate. |
- |
-2011-02-04 Pavel Podivilov <podivilov@chromium.org> |
- |
- Reviewed by Pavel Feldman. |
- |
- Web Inspector: evaluate on hover does not work on a breakpoint. |
- https://bugs.webkit.org/show_bug.cgi?id=53768 |
- |
- * inspector/front-end/SourceFrame.js: |
- (WebInspector.SourceFrame.prototype._mouseHover): |
- |
-2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com> |
- |
- Unreviewed, rolling out r77625 and r77626. |
- http://trac.webkit.org/changeset/77625 |
- http://trac.webkit.org/changeset/77626 |
- https://bugs.webkit.org/show_bug.cgi?id=53765 |
- |
- It broke Windows builds (Requested by Ossy_ on #webkit). |
- |
- * Android.jscbindings.mk: |
- * CMakeLists.txt: |
- * ForwardingHeaders/pcre/pcre.h: Added. |
- * ForwardingHeaders/yarr/Yarr.h: Removed. |
- * ForwardingHeaders/yarr/YarrInterpreter.h: Removed. |
- * ForwardingHeaders/yarr/YarrPattern.h: Removed. |
- * WebCore.gyp/WebCore.gyp: |
- * WebCore.pro: |
- * WebCore.vcproj/WebCore.vcproj: |
- * WebCore.vcproj/copyForwardingHeaders.cmd: |
- * platform/text/RegularExpression.cpp: |
- (WebCore::RegularExpression::Private::regexp): |
- (WebCore::RegularExpression::Private::compile): |
- (WebCore::RegularExpression::Private::Private): |
- (WebCore::RegularExpression::Private::create): |
- (WebCore::RegularExpression::Private::~Private): |
- (WebCore::RegularExpression::match): |
- |
-2011-02-04 Peter Varga <pvarga@webkit.org> |
- |
- Rubber-stamped by Csaba Osztrogonác. |
- |
- Replace PCRE with Yarr in WebCore |
- https://bugs.webkit.org/show_bug.cgi?id=53496 |
- |
- Speculative windows build fix. |
- |
- No new tests needed. |
- |
- * platform/text/RegularExpression.cpp: |
- |
-2011-02-04 Peter Varga <pvarga@webkit.org> |
- |
- |
- Reviewed by Gavin Barraclough. |
- |
- Replace PCRE with Yarr in WebCore |
- https://bugs.webkit.org/show_bug.cgi?id=53496 |
- |
- No new tests needed. |
- |
- * Android.jscbindings.mk: |
- * CMakeLists.txt: |
- * ForwardingHeaders/pcre/pcre.h: Removed. |
- * ForwardingHeaders/yarr/Yarr.h: Added. |
- * ForwardingHeaders/yarr/YarrInterpreter.h: Added. |
- * ForwardingHeaders/yarr/YarrPattern.h: Added. |
- * WebCore.gyp/WebCore.gyp: |
- * WebCore.pro: |
- * WebCore.vcproj/WebCore.vcproj: |
- * WebCore.vcproj/copyForwardingHeaders.cmd: |
- * platform/text/RegularExpression.cpp: |
- (WebCore::RegularExpression::Private::create): |
- (WebCore::RegularExpression::Private::Private): |
- (WebCore::RegularExpression::Private::compile): |
- (WebCore::RegularExpression::match): |
- |
-2011-02-04 Pavel Feldman <pfeldman@chromium.org> |
- |
- Reviewed by Yury Semikhatsky. |
- |
- Web Inspector: Network panel filtering is broken. |
- https://bugs.webkit.org/show_bug.cgi?id=53764 |
- |
- * inspector/front-end/NetworkPanel.js: |
- (WebInspector.NetworkPanel.prototype._sortItems): |
- (WebInspector.NetworkPanel.prototype._sortByTimeline): |
- (WebInspector.NetworkPanel.prototype._filter): |
- (WebInspector.NetworkPanel.prototype._updateOffscreenRows): |
- (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): |
- (WebInspector.NetworkDataGridNode.prototype.get selectable): |
- (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): |
- (WebInspector.NetworkTotalGridNode.prototype.get selectable): |
- |
-2011-02-04 Andrey Kosyakov <caseq@chromium.org> |
- |
- Reviewed by Pavel Feldman. |
- |
- Web Inspector: support overriding user agent strings |
- https://bugs.webkit.org/show_bug.cgi?id=51485 |
- |
- Test: http/tests/inspector/extensions-useragent.html |
- |
- * inspector/Inspector.idl: |
- * inspector/InspectorController.cpp: |
- (WebCore::InspectorController::disconnectFrontend): |
- (WebCore::InspectorController::setUserAgentOverride): |
- (WebCore::InspectorController::userAgentOverride): |
- * inspector/InspectorController.h: |
- * inspector/front-end/ExtensionAPI.js: |
- (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload): |
- * inspector/front-end/ExtensionServer.js: |
- (WebInspector.ExtensionServer.prototype._onReload): |
- * loader/FrameLoader.cpp: |
- (WebCore::FrameLoader::userAgent): |
- (WebCore::FrameLoader::applyUserAgent): |
- |
-2011-02-04 Pavel Podivilov <podivilov@chromium.org> |
- |
- Reviewed by Pavel Feldman. |
- |
- Web Inspector: scripts panel displays wrong file name after reload. |
- https://bugs.webkit.org/show_bug.cgi?id=53761 |
- |
- * inspector/front-end/ScriptsPanel.js: |
- (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): |
- |
-2011-02-03 Yury Semikhatsky <yurys@chromium.org> |
- |
- Reviewed by Pavel Feldman. |
- |
- Web Inspector: remove settings related methods from InspectorClient |
- https://bugs.webkit.org/show_bug.cgi?id=53686 |
- |
- * WebCore.exp.in: |
- * inspector/CodeGeneratorInspector.pm: |
- * inspector/InspectorClient.h: |
- * inspector/InspectorFrontendClientLocal.cpp: |
- (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): |
- (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): |
- (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight): |
- * inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can |
- provide platform-specific settings accessor. |
- (WebCore::InspectorFrontendClientLocal::Settings::Settings): |
- (WebCore::InspectorFrontendClientLocal::Settings::~Settings): |
- (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight): |
- (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight): |
- * loader/EmptyClients.h: |
- |
2011-02-03 Anton Muhin <antonm@chromium.org> |
Reviewed by Adam Barth. |
- [v8] frame several more JS code invocations into v8::TryCatch |
- https://bugs.webkit.org/show_bug.cgi?id=53594 |
+ [v8] Bail out if to string conversion returned empty handle |
+ https://bugs.webkit.org/show_bug.cgi?id=53687 |
- This patch is preemptive and adjusts v8 bindings code to forthcoming small change |
- in v8::ThrowException---currently sometimes exceptions thrown by this method |
- do not reach surrounding v8::TryCatch handler (see |
- http://code.google.com/p/v8/issues/detail?id=1072 and |
- http://codereview.chromium.org/6397011/). Therefore the goal of this patch |
- is to make forthcoming v8 roll as smooth as possible (alas, we'll still need |
- one rebaseline as of now.) |
+ This a temporary measure: actually one probably should never get empty handle |
+ if there was no exception. The root cause is under investigation. |
+ The bailout though allows Chromium not to crash---attempt to convert an empty |
+ v8 hande into WebCore string crashes with invalid memory access. |
- * bindings/v8/V8Proxy.cpp: |
- (WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead |
- * bindings/v8/V8WindowErrorHandler.cpp: |
- (WebCore::V8WindowErrorHandler::callListenerFunction): Ditto |
+ See http://code.google.com/p/chromium/issues/detail?id=71544 |
-2011-02-03 Maciej Stachowiak <mjs@apple.com> |
+ There is no known reduction expressible as a layout test so far. The crash found with automated testing tools. |
- Reviewed by Dan Bernstein. |
+ * bindings/v8/V8Binding.cpp: |
+ (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle |
+ * bindings/v8/V8Binding.h: |
+ (WebCore::V8ParameterBase::prepareBase): Ditto |
- WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle |
- https://bugs.webkit.org/show_bug.cgi?id=52897 |
- <rdar://problem/8898294> |
- |
- * WebCore.exp.in: Add export now needed by WebKit2 |
- |
-2011-02-03 Victoria Kirst <vrk@google.com> |
- |
- Reviewed by James Robinson. |
- |
- Replaces float literals with uniform values in shader code |
- so that buggy drivers unable to parse float values in different |
- locales will not produce a pink video. |
- |
- [chromium] Fix pink video bug with gpu-acceleration enabled |
- https://bugs.webkit.org/show_bug.cgi?id=53568 |
- |
- * platform/graphics/chromium/VideoLayerChromium.cpp: |
- (WebCore::VideoLayerChromium::SharedValues::SharedValues): |
- (WebCore::VideoLayerChromium::drawYUV): |
- * platform/graphics/chromium/VideoLayerChromium.h: |
- (WebCore::VideoLayerChromium::SharedValues::signAdjLocation): |
- |
-2011-02-03 James Kozianski <koz@chromium.org> |
- |
- Reviewed by Dimitri Glazkov. |
- |
- Add navigator.registerProtocolHandler behind a flag. |
- https://bugs.webkit.org/show_bug.cgi?id=52609 |
- |
- This method is described in the HTML5 specification here, |
- http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler |
- |
- This change is largely cribbed from B. Green's 29651 patches. It is |
- behind a flag so as not to break JS feature detection. |
- |
- New layout test fast/dom/registerProtocolHandler.html. |
- |
- * Configurations/FeatureDefines.xcconfig: |
- * loader/EmptyClients.h: |
- (WebCore::EmptyChromeClient::registerProtocolHandler): |
- * page/Chrome.cpp: |
- (WebCore::Chrome::registerProtocolHandler): |
- * page/Chrome.h: |
- * page/ChromeClient.h: |
- * page/Navigator.cpp: |
- (WebCore::verifyCustomHandlerURL): |
- (WebCore::verifyProtocolHandlerScheme): |
- (WebCore::Navigator::registerProtocolHandler): |
- * page/Navigator.h: |
- * page/Navigator.idl: |
- |
-2011-02-03 Brian Ryner <bryner@chromium.org> |
- |
- Reviewed by Darin Fisher. |
- |
- Add a field to the ResourceResponse for tracking the socket address |
- of the host that the resource was fetched from. Patch was originally |
- by Paul Marks. |
- https://bugs.webkit.org/show_bug.cgi?id=53699 |
- |
- * platform/network/chromium/ResourceResponse.cpp: |
- (WebCore::ResourceResponse::doPlatformCopyData): |
- (WebCore::ResourceResponse::doPlatformAdopt): |
- * platform/network/chromium/ResourceResponse.h: |
- (WebCore::ResourceResponse::socketAddress): |
- (WebCore::ResourceResponse::setSocketAddress): |
- |
-2011-02-03 Adam Langley <agl@chromium.org> |
- |
- Reviewed by Adam Barth. |
- |
- Plumb mixed script URL to FrameLoaderClient |
- https://bugs.webkit.org/show_bug.cgi?id=52384 |
- |
- Regressions covered by http/tests/security/mixedContent/* |
- |
- * loader/EmptyClients.h: |
- (WebCore::EmptyFrameLoaderClient::didRunInsecureContent): |
- * loader/FrameLoader.cpp: |
- (WebCore::FrameLoader::checkIfRunInsecureContent): |
- * loader/FrameLoaderClient.h: |
- |
-2011-02-03 Simon Fraser <simon.fraser@apple.com> |
- |
- Reviewed by Dan Bernstein. |
- |
- REGRESSION: Artifacts on box-shadow corners in some cases |
- https://bugs.webkit.org/show_bug.cgi?id=53731 |
- |
- Fix overdrawing artifacts in ShadowBlur's tiling code path, |
- which show up in shadows using a color with alpha. |
- |
- Test: fast/box-shadow/shadow-tiling-artifact.html |
- |
- * platform/graphics/ShadowBlur.cpp: |
- (WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure |
- that the inner rect that gets filled does not overlap with any |
- of the eight tiled areas by having the corner and side dimensions |
- be the same for contiguous areas. |
- |
2011-02-03 Adam Barth <abarth@webkit.org> |
Reviewed by Alexey Proskuryakov. |