Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 6368069: factory-utils: add factory scripts from crosutils (copy only) (Closed)

Created:
8 years, 6 months ago by zbehan
Modified:
8 years, 3 months ago
Reviewers:
Nick Sanders, anush
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git.chromium.org/factory-utils@master
Visibility:
Public.

Description

factory-utils: add factory scripts from crosutils (copy only) BUG=n0ne TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b67893d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+835 lines, -0 lines) Patch
A cros_sign_to_ssd View 1 chunk +92 lines, -0 lines 0 comments Download
A make_factory_package.sh View 1 1 chunk +426 lines, -0 lines 0 comments Download
A mk_memento_images_factory.sh View 1 1 chunk +135 lines, -0 lines 0 comments Download
A serve_factory_packages.py View 1 chunk +182 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
zbehan
8 years, 6 months ago (2011-02-03 05:59:55 UTC) #1
Nick Sanders
http://codereview.chromium.org/6368069/diff/1/mk_memento_images.sh File mk_memento_images.sh (right): http://codereview.chromium.org/6368069/diff/1/mk_memento_images.sh#newcode34 mk_memento_images.sh:34: . "${SCRIPT_ROOT}/common.sh" || (echo "Unable to load common.sh" && ...
8 years, 6 months ago (2011-02-04 19:55:13 UTC) #2
zbehan
It's twice in the original, I suspect after greg's huge CL. I merely made a ...
8 years, 6 months ago (2011-02-04 20:09:37 UTC) #3
Nick Sanders
lgtm if you remove the dup line
8 years, 6 months ago (2011-02-04 21:29:27 UTC) #4
Nick Sanders
lgtm to move as is
8 years, 6 months ago (2011-02-05 22:08:40 UTC) #5
zbehan
OK, I'm actually considering a little modification. I'd rename your copy of the script to ...
8 years, 6 months ago (2011-02-05 23:15:51 UTC) #6
anush
My suggestion would be to move as is. And file bugs for refactoring and come ...
8 years, 6 months ago (2011-02-05 23:20:38 UTC) #7
zbehan
At this point, I'm only wanting to do the fork, to free my hands from ...
8 years, 6 months ago (2011-02-05 23:23:07 UTC) #8
anush
thats fine with me if it is ok with nsanders. On Sat, Feb 5, 2011 ...
8 years, 6 months ago (2011-02-05 23:24:30 UTC) #9
Nick Sanders
Agree, refactors and moves should be separate. On Sat, Feb 5, 2011 at 3:15 PM, ...
8 years, 6 months ago (2011-02-05 23:26:34 UTC) #10
Nick Sanders
sgtm. On Sat, Feb 5, 2011 at 3:24 PM, Anush Elangovan(அனுஷ்) <anush@chromium.org>wrote: > thats fine ...
8 years, 6 months ago (2011-02-05 23:27:18 UTC) #11
zbehan
2011/2/6 Nick Sanders <nsanders@chromium.org> > Agree, refactors and moves should be separate. > > On ...
8 years, 6 months ago (2011-02-05 23:29:53 UTC) #12
zbehan
8 years, 6 months ago (2011-02-06 03:22:03 UTC) #13
zbehan
8 years, 6 months ago (2011-02-06 03:25:11 UTC) #14
mk_memento_images renamed, and reference changed. I also removed the
duplicate line.

Also, this CL intends to "move" the scripts, with as few modifications as
possible. After I introduce the ebuild to install these, I'll submit another
subsequent CL to fix all necessary paths and test things if they work. Then
I'll remove these from crosutils.

On Sun, Feb 6, 2011 at 4:22 AM, <zbehan@chromium.org> wrote:

> http://codereview.chromium.org/6368069/
>

Powered by Google App Engine
This is Rietveld 408576698