Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 6368059: Enable toast for 597.... (Closed)

Created:
9 years, 10 months ago by Mark Larson
Modified:
9 years, 7 months ago
CC:
chromium-reviews, laforge
Visibility:
Public.

Description

Enable toast for 597. 1. Merge r69465: Enable Japanese inactive user toast experiments. 2. Merge r69835: Fixes update step to not clobber client code setting if toast experiment is not active. 3. Change experiment_enabled to true 4. Remove the en_US exeriment, enable experiment for ja 5. For locale != ja, use message flavor 2, "There's a new, safer version of Chrome available." 6. Change client codes to a new namespace for the Japan experiment (S{JKLM}xx) R= cpu, gwilson BUG= none TOAST= yeah! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73572

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
MM chrome/installer/util/google_chrome_distribution.cc View 1 4 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Larson
Toast changes for 597 are ready for review. I've already gone over this face-to-face with ...
9 years, 10 months ago (2011-02-02 21:19:07 UTC) #1
Mark Larson
Oops. Sent out a "please review" email without adding any actual reviewers...
9 years, 10 months ago (2011-02-03 00:37:43 UTC) #2
cpu_(ooo_6.6-7.5)
9 years, 10 months ago (2011-02-03 00:44:51 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698