Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 636773002: Extended java_cpp_enum to parse enums with set values (Closed)

Created:
6 years, 2 months ago by sashab
Modified:
6 years, 2 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@page_info_dialog_shell_only_v2
Project:
chromium
Visibility:
Public.

Description

Extended java_cpp_enum to parse enums with set values Extended java_cpp_enum to parse enums that have values set for some of the enums. Also fixed a small bug where enum values with comments on the same line (following the enum) were being ignored. BUG=NONE Committed: https://crrev.com/8bf011fd19739f5b6c85c87e0928de84ed487476 Cr-Commit-Position: refs/heads/master@{#299009}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Indentation fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M build/android/gyp/java_cpp_enum.py View 1 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sashab
This is required work for generating an Android enum from components/content_settings/core/common/content_settings_types.h.
6 years, 2 months ago (2014-10-07 04:46:10 UTC) #2
cjhopman
lgtm https://codereview.chromium.org/636773002/diff/1/build/android/gyp/java_cpp_enum.py File build/android/gyp/java_cpp_enum.py (right): https://codereview.chromium.org/636773002/diff/1/build/android/gyp/java_cpp_enum.py#newcode52 build/android/gyp/java_cpp_enum.py:52: 'for key %s.' % (value, key)) nit: indent ...
6 years, 2 months ago (2014-10-08 17:40:37 UTC) #3
sashab
https://codereview.chromium.org/636773002/diff/1/build/android/gyp/java_cpp_enum.py File build/android/gyp/java_cpp_enum.py (right): https://codereview.chromium.org/636773002/diff/1/build/android/gyp/java_cpp_enum.py#newcode52 build/android/gyp/java_cpp_enum.py:52: 'for key %s.' % (value, key)) On 2014/10/08 17:40:36, ...
6 years, 2 months ago (2014-10-08 22:34:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636773002/20001
6 years, 2 months ago (2014-10-09 22:28:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-09 23:48:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 23:49:30 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bf011fd19739f5b6c85c87e0928de84ed487476
Cr-Commit-Position: refs/heads/master@{#299009}

Powered by Google App Engine
This is Rietveld 408576698