Issue 63673006: Fix cancelling of device enumeration requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63673006: Fix cancelling of device enumeration requests. (Closed)

Created:
7 years, 1 month ago by perkj_chrome

Modified:
7 years, 1 month ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix cancelling of device enumeration requests. TEST= Log using --vmodule=media_stream_manager*=3,media_stream_dispatcher*=3 and make sure the log print out media_stream_manager.cc(316)]CancelRequest( after MediaStreamDispatcher::StopEnumerateDevices() while using the webcam on youtube.com/my_webcam?privacy=public BUG=317534, 320421 R=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235720

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add log. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	content/browser/renderer_host/media/media_stream_dispatcher_host.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

perkj_chrome

Can you please take a look? I reverted https://codereview.chromium.org/72683002/.

7 years, 1 month ago (2013-11-18 09:48:29 UTC) #1

tommi (sloooow) - chröme

lgtm https://codereview.chromium.org/63673006/diff/1/content/browser/renderer_host/media/media_stream_dispatcher_host.cc File content/browser/renderer_host/media/media_stream_dispatcher_host.cc (right): https://codereview.chromium.org/63673006/diff/1/content/browser/renderer_host/media/media_stream_dispatcher_host.cc#newcode199 content/browser/renderer_host/media/media_stream_dispatcher_host.cc:199: // OnCancelEnumerateDevices can be called several times with ...

7 years, 1 month ago (2013-11-18 10:01:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/63673006/60001

7 years, 1 month ago (2013-11-18 10:11:28 UTC) #3

Message was sent while issue was closed.

Change committed as 235720

Expand Messages | Collapse Messages