Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Issue 63673003: Mojo: Add DCHECKs to entrypoints that CoreImpl has been initialized. (Closed)

Created:
7 years, 1 month ago by viettrungluu
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Add DCHECKs to entrypoints that CoreImpl has been initialized. R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M mojo/system/core.cc View 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
7 years, 1 month ago (2013-11-11 18:31:53 UTC) #1
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-11 18:41:42 UTC) #2
viettrungluu
7 years, 1 month ago (2013-11-11 19:23:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r234256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698