chrome/browser/translate/translate_manager_render_view_host_unittest.cc - Issue 636673002: Remove navigation from TestRenderViewHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 636673002: Remove navigation from TestRenderViewHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes from self-review Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('K') | « chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('k') | chrome/test/base/browser_with_test_window_test.cc » ('j') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

index 135536cefe104a5017e0a46a769c4ea6b7886b44..38d6ec2d0955c57a9c4f146cefafcf96a55aba3c 100644

--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

@@ -840,8 +840,8 @@ TEST_F(TranslateManagerRenderViewHostTest, ReloadFromLocationBar) {

NavEntryCommittedObserver nav_observer(web_contents());

web_contents()->GetController().LoadURL(

url, content::Referrer(), ui::PAGE_TRANSITION_TYPED, std::string());

- rvh_tester()->SendNavigateWithTransition(

- 0, url, ui::PAGE_TRANSITION_TYPED);

+ content::RenderFrameHostTester::For(web_contents()->GetMainFrame())

+ ->SendNavigateWithTransition(0, url, ui::PAGE_TRANSITION_TYPED);

// Test that we are really getting a same page navigation, the test would be

// useless if it was not the case.