Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 636663002: gn format: fix some cases of too many blank lines between items (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format: fix some cases of too many blank lines between items R=brettw@chromium.org BUG=348474 Committed: https://crrev.com/785ffa786a39e0b98ff3ebf1dfeec3c47340fd15 Cr-Commit-Position: refs/heads/master@{#298341}

Patch Set 1 #

Patch Set 2 : gn format: fix some cases of too many blank lines between items #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M tools/gn/command_format.cc View 1 3 chunks +36 lines, -1 line 0 comments Download
M tools/gn/command_format_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/028.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/028.golden View 1 1 chunk +5 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/029.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/029.golden View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scottmg
6 years, 2 months ago (2014-10-06 22:37:27 UTC) #2
brettw
LGTM, I think it makes sense that some things always have a blank line bewteen ...
6 years, 2 months ago (2014-10-06 22:41:01 UTC) #3
scottmg
On 2014/10/06 22:41:01, brettw wrote: > LGTM, I think it makes sense that some things ...
6 years, 2 months ago (2014-10-06 22:43:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636663002/20001
6 years, 2 months ago (2014-10-06 22:53:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5a29bde628f5cd6c7f9a40360c5079926995900c
6 years, 2 months ago (2014-10-07 02:52:31 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 02:53:34 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/785ffa786a39e0b98ff3ebf1dfeec3c47340fd15
Cr-Commit-Position: refs/heads/master@{#298341}

Powered by Google App Engine
This is Rietveld 408576698