Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 636593002: Restore a really single-threaded mode to DM. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Restore a really single-threaded mode to DM. Used to be: 0 -> run on main thread plus an autodetected number of extra threads (default) N -> run on main thread plus N extra threads Now it's: -1 -> run on main thread plus an autodetected number of extra threads (default) 0 -> run on main thread N -> run on main thread plus N extra threads BUG=skia: Committed: https://skia.googlesource.com/skia/+/e356c7f0eeb513d0b8cf7bf7f1f47ba4e997861e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/utils/SkTaskGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkTaskGroup.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years, 2 months ago (2014-10-06 18:06:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636593002/1
6 years, 2 months ago (2014-10-06 18:07:03 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-06 18:07:03 UTC) #5
mtklein
lgtm
6 years, 2 months ago (2014-10-06 18:23:16 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 18:24:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as e356c7f0eeb513d0b8cf7bf7f1f47ba4e997861e

Powered by Google App Engine
This is Rietveld 408576698