Issue 636493004: Revert Add a use counter for Intl.v8BreakIterator https://codereview.chromium.org/619913002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 636493004: Revert Add a use counter for Intl.v8BreakIterator https://codereview.chromium.org/619913002/ (Closed)

Created:
6 years, 2 months ago by Erik Corry Chromium.org

Modified:
6 years, 2 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert Add a use counter for Intl.v8BreakIterator https://codereview.chromium.org/619913002/ This is due to breakage on the ASAN memory leak bot, possibly due to pre-existing leaks in v8BreakIterator(). R=ishell@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24409

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -32 lines)			Patch
M	include/v8.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/i18n.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+0 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

Erik Corry Chromium.org

6 years, 2 months ago (2014-10-06 11:14:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24409 (presubmit successful).