Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 63643003: Fix not resuming a request after a plugin calls NPN_URLRedirectResponse. (Closed)

Created:
7 years, 1 month ago by jam
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix not resuming a request after a plugin calls NPN_URLRedirectResponse. BUG=301510 TEST=http://www.dbtv.no/?vid=2750870727001 plays R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233516

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
jam
7 years, 1 month ago (2013-11-07 04:42:45 UTC) #1
scottmg
the test url plays ok for me in Canary, is that expected? https://codereview.chromium.org/63643003/diff/1/content/child/npapi/plugin_url_fetcher.cc File content/child/npapi/plugin_url_fetcher.cc ...
7 years, 1 month ago (2013-11-07 04:48:55 UTC) #2
scottmg
(lgtm in any case, i'm assuming you had some non-working case)
7 years, 1 month ago (2013-11-07 04:49:23 UTC) #3
jam
On 2013/11/07 04:48:55, scottmg wrote: > the test url plays ok for me in Canary, ...
7 years, 1 month ago (2013-11-07 04:58:18 UTC) #4
scottmg
7 years, 1 month ago (2013-11-07 05:01:27 UTC) #5
On 2013/11/07 04:58:18, jam wrote:
> On 2013/11/07 04:48:55, scottmg wrote:
> > the test url plays ok for me in Canary, is that expected?
> 
> This is only busted with NPAPI Flash, I assume you were using Pepper Flash?

ah, of course "NPN_". yes.

> 
>
https://codereview.chromium.org/63643003/diff/1/content/child/npapi/plugin_ur...
> File content/child/npapi/plugin_url_fetcher.cc (right):
> 
>
https://codereview.chromium.org/63643003/diff/1/content/child/npapi/plugin_ur...
> content/child/npapi/plugin_url_fetcher.cc:148:
bridge_->SetDefersLoading(false);
> On 2013/11/07 04:48:55, scottmg wrote:
> > this is the response to OnReceivedRedirect?
> 
> this is called by the plugin after we hit a redirect and had paused the
request
> while waiting for the plugin to call us back and let us know whether to follow
> the redirect or not

got it, lgtm.

Powered by Google App Engine
This is Rietveld 408576698