src/ast-numbering.h - Issue 636403003: Assign bailout and type feedback IDs in a post-pass

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/ast-numbering.h

Issue 636403003: Assign bailout and type feedback IDs in a post-pass (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 the V8 project authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef V8_AST_NUMBERING_H_

	6 #define V8_AST_NUMBERING_H_

	7

	8 namespace v8 {

	9 namespace internal {

	10

	11 class CompilationInfo;

	12

	13 class AstNumbering {
	Sven Panne 2014/10/15 07:41:56 This is not really a class, using a namespace migh This is not really a class, using a namespace might be more honest. wingo 2014/10/15 13:53:19 Done. Show quoted text On 2014/10/15 07:41:56, Sven Panne wrote: > This is not really a class, using a namespace might be more honest. Done.
	14 public:

	15 // Assign type feedback IDs, bailout IDs, and other state to an AST node
	Sven Panne 2014/10/15 07:41:56 Remove the "and other state" part for now. Remove the "and other state" part for now.
	16 // tree.

	17 //

	18 // Mutates the AST, so the AST should not continue to be used in the case of

	19 // failure.
	Sven Panne 2014/10/15 07:41:56 Actually, this is not true: We just failed to set Actually, this is not true: We just failed to set the IDs, nothing else should have been damaged.
	20 static bool Renumber(FunctionLiteral* function, Zone* zone);

	21 };

	22 }

	23 } // namespace v8::internal

	24

	25 #endif // V8_AST_NUMBERING_H_

OLD	NEW