components/metrics/daily_event_unittest.cc - Issue 636363004: Make remaining parts of components/metrics use metrics namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/daily_event_unittest.cc

Issue 636363004: Make remaining parts of components/metrics use metrics namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/daily_event_unittest.cc

diff --git a/components/metrics/daily_event_unittest.cc b/components/metrics/daily_event_unittest.cc

index d15def116cd5391f4e37f450957909064ce2710e..331cc1b121c6d596b658ff2245cb41d62f8168d9 100644

--- a/components/metrics/daily_event_unittest.cc

+++ b/components/metrics/daily_event_unittest.cc

@@ -38,8 +38,7 @@ class DailyEventTest : public testing::Test {

DailyEventTest() : event_(&prefs_, kTestPrefName, kTestMetricName) {

DailyEvent::RegisterPref(prefs_.registry(), kTestPrefName);

observer_ = new TestDailyObserver();

- scoped_ptr<metrics::DailyEvent::Observer> p(observer_);

- event_.AddObserver(p.Pass());

+ event_.AddObserver(scoped_ptr<DailyEvent::Observer>(observer_));

Ilya Sherman 2014/10/23 21:57:05 Optional nit: Can this use make_scoped_ptr for eve

Alexei Svitkine (slow) 2014/10/24 14:48:42 Done.

}

protected:

« no previous file with comments | « components/metrics/cloned_install_detector.cc ('k') | components/metrics/gpu/gpu_metrics_provider_unittest.cc » ('j') | no next file with comments »