Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 636363004: Make remaining parts of components/metrics use metrics namespace. (Closed)

Created:
6 years, 2 months ago by Alexei Svitkine (slow)
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, piman+watch_chromium.org, lcwu+watch_chromium.org, Ilya Sherman, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make remaining parts of components/metrics use metrics namespace. Cleans up various unnecessary namespace declarations and also fixes some lint errors. Code is reformatted using git cl format. BUG=374763 Committed: https://crrev.com/a63d19ef4e8e279552b41b5561d3f17b41cbc7ce Cr-Commit-Position: refs/heads/master@{#301118}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : make_scoped_ptr #

Patch Set 3 : fix cros compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -110 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/clean_exit_beacon.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M components/metrics/cloned_install_detector.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/metrics/daily_event_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/metrics/gpu/gpu_metrics_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/metrics_service.cc View 14 chunks +46 lines, -54 lines 0 comments Download
M components/metrics/metrics_service_unittest.cc View 6 chunks +10 lines, -16 lines 0 comments Download
M components/metrics/metrics_state_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/net/network_metrics_provider.h View 4 chunks +11 lines, -9 lines 0 comments Download
M components/metrics/net/network_metrics_provider.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/metrics/net/wifi_access_point_info_provider.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/metrics/net/wifi_access_point_info_provider.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/metrics/net/wifi_access_point_info_provider_chromeos.h View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M components/metrics/net/wifi_access_point_info_provider_chromeos.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/metrics/profiler/tracking_synchronizer.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/metrics/serialization/serialization_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Alexei Svitkine (slow)
6 years, 2 months ago (2014-10-23 20:52:06 UTC) #3
Ilya Sherman
Nice! LGTM. https://codereview.chromium.org/636363004/diff/40001/components/metrics/daily_event_unittest.cc File components/metrics/daily_event_unittest.cc (right): https://codereview.chromium.org/636363004/diff/40001/components/metrics/daily_event_unittest.cc#newcode41 components/metrics/daily_event_unittest.cc:41: event_.AddObserver(scoped_ptr<DailyEvent::Observer>(observer_)); Optional nit: Can this use make_scoped_ptr ...
6 years, 2 months ago (2014-10-23 21:57:05 UTC) #5
Alexei Svitkine (slow)
https://codereview.chromium.org/636363004/diff/40001/components/metrics/daily_event_unittest.cc File components/metrics/daily_event_unittest.cc (right): https://codereview.chromium.org/636363004/diff/40001/components/metrics/daily_event_unittest.cc#newcode41 components/metrics/daily_event_unittest.cc:41: event_.AddObserver(scoped_ptr<DailyEvent::Observer>(observer_)); On 2014/10/23 21:57:05, Ilya Sherman wrote: > Optional ...
6 years, 2 months ago (2014-10-24 14:48:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636363004/60001
6 years, 2 months ago (2014-10-24 14:49:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/4832)
6 years, 2 months ago (2014-10-24 15:24:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636363004/80001
6 years, 2 months ago (2014-10-24 15:27:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 2 months ago (2014-10-24 16:19:57 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:20:34 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a63d19ef4e8e279552b41b5561d3f17b41cbc7ce
Cr-Commit-Position: refs/heads/master@{#301118}

Powered by Google App Engine
This is Rietveld 408576698