Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: build/android/pylib/utils/watchdog_timer.py

Issue 636273004: Make TimeoutRetryThread's stoppable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more improvements on TimeoutRetryThread Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/utils/watchdog_timer.py
diff --git a/build/android/pylib/utils/watchdog_timer.py b/build/android/pylib/utils/watchdog_timer.py
index d14dabb4dd7800eb1883fc7aae8cdc2b8f4a538f..9e76e3da57ec952d351798891c11dfb3db368377 100644
--- a/build/android/pylib/utils/watchdog_timer.py
+++ b/build/android/pylib/utils/watchdog_timer.py
@@ -26,12 +26,22 @@ class WatchdogTimer(object):
"""Resets the timeout countdown."""
self._start_time = time.time()
+ def GetElapsed(self):
+ """Returns the elapsed time of the watchdog."""
+ return time.time() - self._start_time
+
+ def GetRemaining(self):
+ """Returns the remaining time of the watchdog."""
+ if self._timeout:
+ return self._start_time + self._timeout - time.time()
jbudorick 2014/10/30 19:00:14 nit: self._timeout - self.GetElapsed()?
+ else:
+ return None
+
def IsTimedOut(self):
"""Whether the watchdog has timed out.
Returns:
True if the watchdog has timed out, False otherwise.
"""
- if self._timeout is None:
- return False
- return time.time() - self._start_time > self._timeout
+ remaining = self.GetRemaining()
+ return remaining is not None and remaining < 0
« build/android/pylib/utils/timeout_retry.py ('K') | « build/android/pylib/utils/timeout_retry.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698