Make TimeoutRetryThread's stoppable

build/android/pylib/utils/timeout_retry.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A utility to run functions with timeouts and retries."""
 # pylint: disable=W0702
 
 import threading
+import time
 
 from pylib.utils import reraiser_thread
 from pylib.utils import watchdog_timer
 
 
 class TimeoutRetryThread(reraiser_thread.ReraiserThread):
-  pass
+  def __init__(self, *args, **kwargs):
+    super(TimeoutRetryThread, self).__init__(*args, **kwargs)
+    self._timeout_expired = False
+    self._start = time.time()
+
+  def ElapsedTime(self):
+    return time.time() - self._start
+
+  def ExpireTimeout(self):
+    self._timeout_expired = True
+
+  def CheckTimeout(self):
+    if self._timeout_expired:
+      raise reraiser_thread.TimeoutError('Thread timed out')
 

[perezju, 2014/10/27 17:43:34]

Moved the changes from reraiser_thread into here. Maybe a bit better?

[jbudorick, 2014/10/27 19:15:37]

Definitely, but I'm still not a fan of making the client figure out whether it
has timed out or not.

 
 def Run(func, timeout, retries, args=None, kwargs=None):
   """Runs the passed function in a separate thread with timeouts and retries.
 
   Args:
     func: the function to be wrapped.
     timeout: the timeout in seconds for each try.
     retries: the number of retries.
     args: list of positional args to pass to |func|.
     kwargs: dictionary of keyword args to pass to |func|.
 
   Returns:
     The return value of func(*args, **kwargs).
   """
   if not args:
     args = []
   if not kwargs:
     kwargs = {}
 
   # The return value uses a list because Python variables are references, not
   # values. Closures make a copy of the reference, so updating the closure's
   # reference wouldn't update where the original reference pointed.
   ret = [None]
   def RunOnTimeoutThread():
     ret[0] = func(*args, **kwargs)
 
+  num_try = 1
   while True:
+    child_thread = TimeoutRetryThread(
+      RunOnTimeoutThread,
+      name='TimeoutThread-%d-for-%s' % (num_try,
+                                        threading.current_thread().name))

[perezju, 2014/10/27 17:43:34]

With, say, 3 retries, thread numbers now count from 1, 2, 3, 4.

     try:
-      name = 'TimeoutThread-for-%s' % threading.current_thread().name
-      thread_group = reraiser_thread.ReraiserThreadGroup(
-          [TimeoutRetryThread(RunOnTimeoutThread, name=name)])
+      thread_group = reraiser_thread.ReraiserThreadGroup([child_thread])
       thread_group.StartAll()
       thread_group.JoinAll(watchdog_timer.WatchdogTimer(timeout))
       return ret[0]
     except:
-      if retries <= 0:
+      child_thread.ExpireTimeout()
+      if num_try > retries:
         raise
-      retries -= 1
+      num_try += 1