Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 636233006: Reland "Fix scheduler to correctly schedule nested diamonds". (Closed)

Created:
6 years, 2 months ago by sigurds
Modified:
6 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Fix scheduler to correctly schedule nested diamonds". Reland fix: Consume less memory. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24597

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Possible fix. #

Patch Set 4 : Fix fix ifx #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -4 lines) Patch
M src/compiler/scheduler.cc View 1 2 3 5 chunks +45 lines, -4 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 3 chunks +83 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurds
I got rid of the helper data-structure. I'd like to land it to see if ...
6 years, 2 months ago (2014-10-14 11:20:52 UTC) #1
Michael Starzinger
LGTM (mostly rubber-stamped).
6 years, 2 months ago (2014-10-14 11:59:53 UTC) #2
sigurds
6 years, 2 months ago (2014-10-14 12:09:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698