Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 63623002: [CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly (Closed)

Created:
7 years, 1 month ago by Hans Muller
Modified:
7 years, 1 month ago
Reviewers:
Zoltan, eseidel
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly RasterShapeIntervals::getExcludedIntervals() was returning an empty list when the line overlapped any vertical gap in the image. This short-circuit had been mistakenly copied from getIncludedIntervals(), where it makes sense. BUG=315918 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161542

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed "-webkit" prefix from the test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap-expected.html View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/rendering/shapes/RasterShape.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hans Muller
A small fix. Not really a small problem.
7 years, 1 month ago (2013-11-07 01:56:36 UTC) #1
Zoltan
other than that small nit lgtm https://codereview.chromium.org/63623002/diff/1/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html File LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html (right): https://codereview.chromium.org/63623002/diff/1/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html#newcode12 LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html:12: -webkit-shape-outside: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' ...
7 years, 1 month ago (2013-11-07 02:07:41 UTC) #2
eseidel
7 years, 1 month ago (2013-11-07 08:14:01 UTC) #3
eseidel
lgtm
7 years, 1 month ago (2013-11-07 08:14:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hmuller@adobe.com/63623002/60001
7 years, 1 month ago (2013-11-07 15:38:25 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 16:46:04 UTC) #6
Message was sent while issue was closed.
Change committed as 161542

Powered by Google App Engine
This is Rietveld 408576698