Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: tools/telemetry/telemetry/value/summary.py

Issue 636203002: Task Execution Duration metrics added as a new benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/summary.py
diff --git a/tools/telemetry/telemetry/value/summary.py b/tools/telemetry/telemetry/value/summary.py
index 13e8ac20dfc52ba5b387fa9940d4d82099cbc6f5..c2dbf2efd6cab42ccc692e17ac85524631616ea9 100644
--- a/tools/telemetry/telemetry/value/summary.py
+++ b/tools/telemetry/telemetry/value/summary.py
@@ -42,6 +42,9 @@ class Summary(object):
self._computed_per_page_values = []
self._computed_summary_values = []
self._interleaved_computed_per_page_values_and_summaries = []
+ self._only_summary = any(
+ isinstance(skip_me, skip.SkipValue) and skip_me.onlySummaries
+ for skip_me in all_page_specific_values)
Sami 2014/10/08 14:51:53 nit: the wrapping here is misleading since the sec
picksi1 2014/10/08 15:58:27 Oops. Missed this comment. Will fix on next round
picksi1 2014/10/09 09:48:50 Done.
self._ComputePerPageValues(all_page_specific_values)
@property
@@ -132,7 +135,7 @@ class Summary(object):
num_successful_pages_for_value_name[value_name])
for per_page_value in sorted_per_page_values:
self._ComputePerPageValue(per_page_value,
- num_successful_pages_for_this_value_name)
+ num_successful_pages_for_this_value_name)
petrcermak 2014/10/08 14:01:48 Invalid indentation
Sami 2014/10/08 14:51:53 Accidental change?
picksi1 2014/10/08 15:01:38 Done.
# Output the combined values.
merged_pages_value = merged_pages_value_by_value_name.get(value_name,
@@ -147,7 +150,10 @@ class Summary(object):
# If there were any page errors, we typically will print nothing.
#
# Note: this branch is structured less-densely to improve legibility.
- if num_successful_pages_for_this_value_name > 1:
+
+ if self._only_summary:
+ should_print = False
+ elif num_successful_pages_for_this_value_name > 1:
should_print = True
elif (self.had_failures and
num_successful_pages_for_this_value_name == 1):
« tools/telemetry/telemetry/value/skip.py ('K') | « tools/telemetry/telemetry/value/skip.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698