Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 636173003: repair the webtry setup process (Closed)

Created:
6 years, 2 months ago by humper
Modified:
6 years, 2 months ago
Reviewers:
tfarina, jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Project:
skia
Visibility:
Public.

Description

repair the webtry setup process The previous version of the script didn't properly update the code for the webtry user, so only changes to skia would really be pulled, not changes to the actual webtry server itself. This version of the setup script is 100% automated and brings everything up to date. It's also a little more verbose about what it's doing, so it's easier to debug. BUG=skia: R=tfarina@chromium.org TBR=jcgregorio, mtklein, tfarina Committed: https://skia.googlesource.com/skia/+/117ff1c1d1d8c27c8c4fa022c5bdb58f291e064d

Patch Set 1 #

Total comments: 2

Patch Set 2 : tfarina's updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -14 lines) Patch
M experimental/webtry/setup/continue_install.sh View 2 chunks +22 lines, -10 lines 0 comments Download
M experimental/webtry/setup/continue_install_jail.sh View 1 1 chunk +1 line, -2 lines 0 comments Download
M experimental/webtry/setup/webtry_setup.sh View 1 4 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
humper
ptal
6 years, 2 months ago (2014-10-08 15:41:54 UTC) #1
tfarina
lgtm it looks good. thanks. https://codereview.chromium.org/636173003/diff/1/experimental/webtry/setup/continue_install_jail.sh File experimental/webtry/setup/continue_install_jail.sh (right): https://codereview.chromium.org/636173003/diff/1/experimental/webtry/setup/continue_install_jail.sh#newcode42 experimental/webtry/setup/continue_install_jail.sh:42: while here, remove this ...
6 years, 2 months ago (2014-10-08 16:01:14 UTC) #2
humper
On 2014/10/08 16:01:14, tfarina wrote: > lgtm > > it looks good. thanks. > > ...
6 years, 2 months ago (2014-10-08 16:13:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636173003/20001
6 years, 2 months ago (2014-10-08 16:15:38 UTC) #5
humper
6 years, 2 months ago (2014-10-08 16:33:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
117ff1c1d1d8c27c8c4fa022c5bdb58f291e064d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698