Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 636093002: Add SandboxPrioritizedOriginDatabase support for dump_file_system (Closed)

Created:
6 years, 2 months ago by tzik
Modified:
6 years, 2 months ago
Reviewers:
nhiroki, hamaji
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik, Takashi Toyoshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add SandboxPrioritizedOriginDatabase support for dump_file_system Origin database of FileSystem API performs special handling for Apps V2. This CL updates dump_file_system to support it. BUG=421330 NOTRY=True Committed: https://crrev.com/5f318980ce040fb8b21529e8ecc5fdbec883159f Cr-Commit-Position: refs/heads/master@{#300254}

Patch Set 1 #

Patch Set 2 : +comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M storage/browser/fileapi/dump_file_system.cc View 1 4 chunks +18 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.h View 2 chunks +4 lines, -0 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tzik
PTL
6 years, 2 months ago (2014-10-08 06:47:07 UTC) #2
nhiroki
LGTM (sorry for my delayed response!)
6 years, 2 months ago (2014-10-14 03:20:01 UTC) #3
hamaji
lgtm
6 years, 2 months ago (2014-10-14 05:28:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636093002/20001
6 years, 2 months ago (2014-10-14 05:50:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17429)
6 years, 2 months ago (2014-10-14 05:57:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636093002/40001
6 years, 2 months ago (2014-10-20 12:37:58 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-20 12:38:25 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 12:39:05 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f318980ce040fb8b21529e8ecc5fdbec883159f
Cr-Commit-Position: refs/heads/master@{#300254}

Powered by Google App Engine
This is Rietveld 408576698