Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 636083003: Make the uninstall dialog use the correct parent window on Athena (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use the associated contents instead of the extensions::WindowController to get the parent window for the "uninstall prompt" dialog. This results in the correct parent window used for uninstall dialogs on Athena because there is no extensions::WindowController for Athena. BUG=414341 TEST=None Committed: https://crrev.com/b3d3cef2bec5fd09245d0038bf5decdfaa500642 Cr-Commit-Position: refs/heads/master@{#300545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
rockot@ can you please take a look? management.createAppShortcut is also problematic on Athena but I ...
6 years, 2 months ago (2014-10-21 16:05:55 UTC) #2
Ken Rockot(use gerrit already)
LGTM but please fix the CL description. It's fine to make a note of why ...
6 years, 2 months ago (2014-10-21 18:31:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636083003/1
6 years, 2 months ago (2014-10-21 19:01:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 20:13:12 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 20:15:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3d3cef2bec5fd09245d0038bf5decdfaa500642
Cr-Commit-Position: refs/heads/master@{#300545}

Powered by Google App Engine
This is Rietveld 408576698