Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: third_party/opus/BUILD.gn

Issue 636083002: Remove obsoleted target_arch==armv7 from opus.gyp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use OS=="linux". Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/opus/opus.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/opus/BUILD.gn
diff --git a/third_party/opus/BUILD.gn b/third_party/opus/BUILD.gn
index 686a6b958dcd0bffe8fc30b22568f00c06f89040..2e9575639bd7b035f2335e9eb7cfbba52752e839 100644
--- a/third_party/opus/BUILD.gn
+++ b/third_party/opus/BUILD.gn
@@ -5,14 +5,15 @@
import("//build/config/arm.gni")
# If fixed point implementation shall be used (otherwise float).
-use_opus_fixed_point = ((is_android || is_chromeos ||
- (is_ios && arm_version == 7)) && cpu_arch == "arm")
+use_opus_fixed_point = (cpu_arch == "arm" || cpu_arch == "arm64")
# If ARM optimizations shall be used to accelerate performance.
-use_opus_arm_optimization = use_opus_fixed_point
+use_opus_arm_optimization = (cpu_arch == "arm")
# If OPUS Run Time CPU Detections (RTCD) shall be used.
-use_opus_rtcd = ((is_android || is_chromeos) && cpu_arch == "arm")
+# Based on the conditions in celt/arm/armcpu.c:
+# defined(_MSC_VER) || defined(__linux__).
+use_opus_rtcd = (cpu_arch == "arm" && (is_win || is_android || is_linux))
config("opus_config") {
include_dirs = [
@@ -83,6 +84,11 @@ source_set("opus") {
]
}
+ if (!is_debug && is_posix && (cpu_arch == "arm" || cpu_arch == "arm64")) {
+ configs -= [ "//build/config/compiler:optimize" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
+
if (use_opus_fixed_point) {
sources += gypi_values.opus_fixed_sources
« no previous file with comments | « no previous file | third_party/opus/opus.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698