Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/opus/opus.gyp

Issue 636083002: Remove obsoleted target_arch==armv7 from opus.gyp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/opus/opus.gyp
diff --git a/third_party/opus/opus.gyp b/third_party/opus/opus.gyp
index e6c4bcf1b6650754bf901a22b820bde8e64c597c..84e1cb2a27d7e09d988bfec228e4f93b2c1a4270 100644
--- a/third_party/opus/opus.gyp
+++ b/third_party/opus/opus.gyp
@@ -5,17 +5,17 @@
{
'variables': {
'conditions': [
- ['target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64"', {
+ ['target_arch=="arm" or target_arch=="arm64"', {
ajm 2014/10/08 06:19:53 This is broader than the corresponding BUILD.gn co
kjellander_chromium 2014/10/08 07:24:04 Yes, please update BUILD.gn if you want (can be do
ajm 2014/10/08 15:55:00 Done.
'use_opus_fixed_point%': 1,
}, {
'use_opus_fixed_point%': 0,
}],
- ['target_arch=="arm" or target_arch=="armv7"', {
+ ['target_arch=="arm"', {
'use_opus_arm_optimization%': 1,
}, {
'use_opus_arm_optimization%': 0,
}],
- ['target_arch=="arm"', {
+ ['target_arch=="arm" and (OS=="android" or chromeos==1)', {
ajm 2014/10/08 06:19:53 This is what BUILD.gn uses, though technically it
kjellander_chromium 2014/10/08 07:24:04 GN and GYP should be the same, but I don't know en
tlegrand1 2014/10/08 09:03:27 This change is not correct, it is the BUILD.gn tha
ajm 2014/10/08 15:55:00 Done.
'use_opus_rtcd%': 1,
}, {
'use_opus_rtcd%': 0,
@@ -76,7 +76,7 @@
],
},
}],
- ['os_posix==1 and (target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64")', {
+ ['os_posix==1 and (target_arch=="arm" or target_arch=="arm64")', {
'cflags!': ['-Os'],
'cflags': ['-O3'],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698