Remove obsoleted target_arch==armv7 from opus.gyp.

third_party/opus/opus.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'conditions': [
-      ['target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64"', {
+      ['target_arch=="arm" or target_arch=="arm64"', {

[minyue, 2014/10/09 07:49:53]

Has armv7 become arm in the building system?

If so, has use_opus_rtcd been activated for IOs? How could that work? It should
not be able to support rtcd from my understanding.

[ajm, 2014/10/09 15:29:32]

Yes, you now specify armv7 with target_arch=="arm" and arm_version==7.
Not sure what you mean; this condition isn't setting rtcd, just whether to use
fixed-point or not. You can see below the conditions I'm using for rtcd, which
_does not_ include iOS.

         'use_opus_fixed_point%': 1,
       }, {
         'use_opus_fixed_point%': 0,
       }],
-      ['target_arch=="arm" or target_arch=="armv7"', {
+      ['target_arch=="arm"', {
         'use_opus_arm_optimization%': 1,
       }, {
         'use_opus_arm_optimization%': 0,
       }],
-      ['target_arch=="arm"', {

[minyue, 2014/10/09 15:38:10]

With deprecation of armv7, did iOS already end up here. Did any iOS bot get
wrong with rtcd?

Or is armv7 something going to happen but not yet?

[ajm, 2014/10/09 15:42:41]

In our standalone webrtc waterfall, we're still (incorrectly) using
target_arch=armv7, so that was fine. I had a quick look at the Chromium iOS
waterfall and it looks like they're not specifying target_arch at all (at least
in GYP_DEFINES) so I'm not totally sure what's going on there. But it's
certainly not breaking the build.
It was changed quite awhile ago (Dec 2013). If you have a look at the linked
bug:
https://code.google.com/p/webrtc/issues/detail?id=3906

I link to the Chromium bug history for this.

+      ['target_arch=="arm" and (OS=="win" or OS=="android" or desktop_linux==1 or chromeos==1)', {
+        # Based on the conditions in celt/arm/armcpu.c:
+        # defined(_MSC_VER) || defined(__linux__).
         'use_opus_rtcd%': 1,
       }, {
         'use_opus_rtcd%': 0,
       }],
     ],
   },
   'targets': [
     {
       'target_name': 'opus',
       'type': 'static_library',
@@ skipping 40 matching lines @@
           # optimizations are turned off.
           'cflags': [
             '-Wno-#pragma-messages',
           ],
           'xcode_settings': {
             'WARNING_CFLAGS': [
               '-Wno-#pragma-messages',
             ],
           },
         }],
-        ['os_posix==1 and (target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64")', {
+        ['os_posix==1 and (target_arch=="arm" or target_arch=="arm64")', {
           'cflags!': ['-Os'],
           'cflags': ['-O3'],
         }],
         ['use_opus_fixed_point==0', {
           'include_dirs': [
             'src/silk/float',
           ],
           'sources': ['<@(opus_float_sources)'],
         }, {
           'defines': [
@@ skipping 57 matching lines @@
       'sources': [
         'src/src/opus_demo.c',
       ],
       'include_dirs': [
         'src/celt',
         'src/silk',
       ],
     },  # target opus_demo
   ]
 }