Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 636063007: Add Tahoma and other fonts to fallback font list (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Tahoma and other fonts to fallback font list Tahoma is the most important, the others are also necessary for less common languages. (Added to bottom of list so that it doesn't look like a scary diff; this will need to be merged to 38.) R=cpu@chromium.org, eae@chromium.org, shrikant@chromium.org BUG=421856 Committed: https://crrev.com/b651d6618394dd0cbfc7e1a254ef30102107d7c5 Cr-Commit-Position: refs/heads/master@{#298973}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : sort #

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M content/renderer/renderer_font_platform_win.cc View 1 2 3 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
scottmg
6 years, 2 months ago (2014-10-09 19:22:57 UTC) #1
eae
On 2014/10/09 19:22:57, scottmg wrote: LGTM
6 years, 2 months ago (2014-10-09 19:31:35 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 2 months ago (2014-10-09 19:31:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636063007/70001
6 years, 2 months ago (2014-10-09 19:32:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636063007/140001
6 years, 2 months ago (2014-10-09 19:34:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636063007/140001
6 years, 2 months ago (2014-10-09 19:36:56 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 20:42:32 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b651d6618394dd0cbfc7e1a254ef30102107d7c5
Cr-Commit-Position: refs/heads/master@{#298973}

Powered by Google App Engine
This is Rietveld 408576698