Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 636063005: [MemSheriff] Exclude failing tests under Valgrind (Closed)

Created:
6 years, 2 months ago by Derek Bruening
Modified:
6 years, 2 months ago
Reviewers:
jonross
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[MemSheriff] Exclude failing tests under Valgrind BUG=421888 TBR=jonross@chromium.org Committed: https://crrev.com/16f3ab434a1e8046dcbc6cc97299d0a05a0d0952 Cr-Commit-Position: refs/heads/master@{#298880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Bruening
6 years, 2 months ago (2014-10-09 15:13:58 UTC) #1
jonross
On 2014/10/09 15:13:58, Derek Bruening wrote: LGTM I didn't get a failure email from Valgrind ...
6 years, 2 months ago (2014-10-09 15:21:20 UTC) #2
Derek Bruening
Committed patchset #1 (id:1) manually as 16f3ab434a1e8046dcbc6cc97299d0a05a0d0952 (presubmit successful).
6 years, 2 months ago (2014-10-09 15:33:00 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 15:35:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16f3ab434a1e8046dcbc6cc97299d0a05a0d0952
Cr-Commit-Position: refs/heads/master@{#298880}

Powered by Google App Engine
This is Rietveld 408576698