util/test/multiprocess.cc - Issue 635883002: Don’t use using directives (“using namespace”) in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/test/multiprocess.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/test/multiprocess.cc

diff --git a/util/test/multiprocess.cc b/util/test/multiprocess.cc

index df8212d438d27aad0d68a90e71eaeba596289706..795683749405f2c33406156d9d0f83321bf3f644 100644

--- a/util/test/multiprocess.cc

+++ b/util/test/multiprocess.cc

@@ -33,8 +33,6 @@

namespace crashpad {

namespace test {

-using namespace testing;

namespace internal {

struct MultiprocessInfo {

@@ -211,7 +209,7 @@ void Multiprocess::RunChild() {

info_->pipe_c2p_write.reset();

info_->pipe_p2c_read.reset();

- if (Test::HasFailure()) {

+ if (testing::Test::HasFailure()) {

// Trigger the ScopedForbidReturn destructor.

return;

}

« no previous file with comments | « util/test/mac/mach_multiprocess_test.cc ('k') | util/test/multiprocess_exec.cc » ('j') | no next file with comments »