Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: util/mach/exc_server_variants_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/exc_client_variants_test.cc ('k') | util/mach/exception_behaviors_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exc_server_variants_test.cc
diff --git a/util/mach/exc_server_variants_test.cc b/util/mach/exc_server_variants_test.cc
index 5daa81ba1079df6b4b8345c26c23301ca9aa1557..eea6dce6f8e004525b44e21b77a8337b3fe4cdf7 100644
--- a/util/mach/exc_server_variants_test.cc
+++ b/util/mach/exc_server_variants_test.cc
@@ -27,11 +27,14 @@
#include "util/test/mac/mach_errors.h"
#include "util/test/mac/mach_multiprocess.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-using namespace crashpad::test;
-using namespace testing;
+using testing::DefaultValue;
+using testing::Eq;
+using testing::Pointee;
+using testing::Return;
// Fake Mach ports. These aren’t used as ports in these tests, they’re just used
// as cookies to make sure that the correct values get passed to the correct
@@ -1169,3 +1172,5 @@ TEST(ExcServerVariants, ExcServerSuccessfulReturnValue) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/mach/exc_client_variants_test.cc ('k') | util/mach/exception_behaviors_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698