Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: util/test/multiprocess_exec.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/test/multiprocess.cc ('k') | util/test/multiprocess_exec_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/test/multiprocess_exec.h" 15 #include "util/test/multiprocess_exec.h"
16 16
17 #include <fcntl.h> 17 #include <fcntl.h>
18 #include <stdio.h> 18 #include <stdio.h>
19 #include <stdlib.h> 19 #include <stdlib.h>
20 20
21 #include "base/posix/eintr_wrapper.h" 21 #include "base/posix/eintr_wrapper.h"
22 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
23 #include "util/misc/scoped_forbid_return.h" 23 #include "util/misc/scoped_forbid_return.h"
24 #include "util/test/errors.h" 24 #include "util/test/errors.h"
25 #include "util/test/posix/close_multiple.h" 25 #include "util/test/posix/close_multiple.h"
26 26
27 namespace crashpad { 27 namespace crashpad {
28 namespace test { 28 namespace test {
29 29
30 using namespace testing;
31
32 MultiprocessExec::MultiprocessExec() 30 MultiprocessExec::MultiprocessExec()
33 : Multiprocess(), 31 : Multiprocess(),
34 command_(), 32 command_(),
35 arguments_(), 33 arguments_(),
36 argv_() { 34 argv_() {
37 } 35 }
38 36
39 void MultiprocessExec::SetChildCommand( 37 void MultiprocessExec::SetChildCommand(
40 const std::string& command, const std::vector<std::string>* arguments) { 38 const std::string& command, const std::vector<std::string>* arguments) {
41 command_ = command; 39 command_ = command;
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 IGNORE_EINTR(close(STDOUT_FILENO)); 134 IGNORE_EINTR(close(STDOUT_FILENO));
137 HANDLE_EINTR(dup2(dup_orig_stdout_fd, STDOUT_FILENO)); 135 HANDLE_EINTR(dup2(dup_orig_stdout_fd, STDOUT_FILENO));
138 IGNORE_EINTR(close(dup_orig_stdout_fd)); 136 IGNORE_EINTR(close(dup_orig_stdout_fd));
139 137
140 forbid_return.Disarm(); 138 forbid_return.Disarm();
141 FAIL() << ErrnoMessage("execv") << ": " << argv_[0]; 139 FAIL() << ErrnoMessage("execv") << ": " << argv_[0];
142 } 140 }
143 141
144 } // namespace test 142 } // namespace test
145 } // namespace crashpad 143 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/test/multiprocess.cc ('k') | util/test/multiprocess_exec_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698