Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Side by Side Diff: minidump/minidump_string_writer_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_module_writer_test.cc ('k') | minidump/minidump_system_info_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_string_writer.h" 15 #include "minidump/minidump_string_writer.h"
16 16
17 #include <dbghelp.h> 17 #include <dbghelp.h>
18 18
19 #include <string> 19 #include <string>
20 20
21 #include "base/basictypes.h" 21 #include "base/basictypes.h"
22 #include "base/strings/string16.h" 22 #include "base/strings/string16.h"
23 #include "base/strings/stringprintf.h" 23 #include "base/strings/stringprintf.h"
24 #include "gtest/gtest.h" 24 #include "gtest/gtest.h"
25 #include "util/file/string_file_writer.h" 25 #include "util/file/string_file_writer.h"
26 26
27 namespace crashpad {
28 namespace test {
27 namespace { 29 namespace {
28 30
29 using namespace crashpad;
30
31 const MINIDUMP_STRING* MinidumpStringCast(const StringFileWriter& file_writer) { 31 const MINIDUMP_STRING* MinidumpStringCast(const StringFileWriter& file_writer) {
32 return reinterpret_cast<const MINIDUMP_STRING*>(&file_writer.string()[0]); 32 return reinterpret_cast<const MINIDUMP_STRING*>(&file_writer.string()[0]);
33 } 33 }
34 34
35 TEST(MinidumpStringWriter, MinidumpUTF16StringWriter) { 35 TEST(MinidumpStringWriter, MinidumpUTF16StringWriter) {
36 StringFileWriter file_writer; 36 StringFileWriter file_writer;
37 37
38 { 38 {
39 SCOPED_TRACE("unset"); 39 SCOPED_TRACE("unset");
40 file_writer.Reset(); 40 file_writer.Reset();
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 MinidumpUTF8StringCast(file_writer); 192 MinidumpUTF8StringCast(file_writer);
193 EXPECT_EQ(kTestData[index].length, minidump_string->Length); 193 EXPECT_EQ(kTestData[index].length, minidump_string->Length);
194 EXPECT_EQ(0, 194 EXPECT_EQ(0,
195 memcmp(kTestData[index].string, 195 memcmp(kTestData[index].string,
196 minidump_string->Buffer, 196 minidump_string->Buffer,
197 expected_utf8_bytes_with_nul)); 197 expected_utf8_bytes_with_nul));
198 } 198 }
199 } 199 }
200 200
201 } // namespace 201 } // namespace
202 } // namespace test
203 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_module_writer_test.cc ('k') | minidump/minidump_system_info_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698