Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: minidump/minidump_file_writer_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | minidump/minidump_memory_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_file_writer.h" 15 #include "minidump/minidump_file_writer.h"
16 16
17 #include <dbghelp.h> 17 #include <dbghelp.h>
18 18
19 #include <string> 19 #include <string>
20 20
21 #include "base/basictypes.h" 21 #include "base/basictypes.h"
22 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
23 #include "minidump/minidump_stream_writer.h" 23 #include "minidump/minidump_stream_writer.h"
24 #include "minidump/minidump_test_util.h" 24 #include "minidump/minidump_test_util.h"
25 #include "minidump/minidump_writable.h" 25 #include "minidump/minidump_writable.h"
26 #include "util/file/file_writer.h" 26 #include "util/file/file_writer.h"
27 #include "util/file/string_file_writer.h" 27 #include "util/file/string_file_writer.h"
28 28
29 namespace crashpad {
30 namespace test {
29 namespace { 31 namespace {
30 32
31 using namespace crashpad;
32 using namespace crashpad::test;
33
34 TEST(MinidumpFileWriter, Empty) { 33 TEST(MinidumpFileWriter, Empty) {
35 MinidumpFileWriter minidump_file; 34 MinidumpFileWriter minidump_file;
36 StringFileWriter file_writer; 35 StringFileWriter file_writer;
37 ASSERT_TRUE(minidump_file.WriteEverything(&file_writer)); 36 ASSERT_TRUE(minidump_file.WriteEverything(&file_writer));
38 ASSERT_EQ(sizeof(MINIDUMP_HEADER), file_writer.string().size()); 37 ASSERT_EQ(sizeof(MINIDUMP_HEADER), file_writer.string().size());
39 38
40 const MINIDUMP_HEADER* header = 39 const MINIDUMP_HEADER* header =
41 reinterpret_cast<const MINIDUMP_HEADER*>(&file_writer.string()[0]); 40 reinterpret_cast<const MINIDUMP_HEADER*>(&file_writer.string()[0]);
42 41
43 VerifyMinidumpHeader(header, 0, 0); 42 VerifyMinidumpHeader(header, 0, 0);
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 254
256 // It is an error to add a second stream of the same type. 255 // It is an error to add a second stream of the same type.
257 const size_t kStream2Size = 3; 256 const size_t kStream2Size = 3;
258 const MinidumpStreamType kStream2Type = static_cast<MinidumpStreamType>(0x4d); 257 const MinidumpStreamType kStream2Type = static_cast<MinidumpStreamType>(0x4d);
259 const uint8_t kStream2Value = 0xa5; 258 const uint8_t kStream2Value = 0xa5;
260 TestStream stream2(kStream2Type, kStream2Size, kStream2Value); 259 TestStream stream2(kStream2Type, kStream2Size, kStream2Value);
261 ASSERT_DEATH(minidump_file.AddStream(&stream2), "already present"); 260 ASSERT_DEATH(minidump_file.AddStream(&stream2), "already present");
262 } 261 }
263 262
264 } // namespace 263 } // namespace
264 } // namespace test
265 } // namespace crashpad
OLDNEW
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | minidump/minidump_memory_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698