Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: client/simple_string_dictionary_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « client/capture_context_mac_test.cc ('k') | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "client/simple_string_dictionary.h" 15 #include "client/simple_string_dictionary.h"
16 16
17 #include "base/logging.h" 17 #include "base/logging.h"
18 #include "gtest/gtest.h" 18 #include "gtest/gtest.h"
19 19
20 namespace crashpad {
21 namespace test {
20 namespace { 22 namespace {
21 23
22 using namespace crashpad;
23
24 TEST(SimpleStringDictionary, Entry) { 24 TEST(SimpleStringDictionary, Entry) {
25 typedef TSimpleStringDictionary<5, 9, 15> TestMap; 25 typedef TSimpleStringDictionary<5, 9, 15> TestMap;
26 TestMap map; 26 TestMap map;
27 27
28 const TestMap::Entry* entry = TestMap::Iterator(map).Next(); 28 const TestMap::Entry* entry = TestMap::Iterator(map).Next();
29 EXPECT_FALSE(entry); 29 EXPECT_FALSE(entry);
30 30
31 // Try setting a key/value and then verify. 31 // Try setting a key/value and then verify.
32 map.SetKeyValue("key1", "value1"); 32 map.SetKeyValue("key1", "value1");
33 entry = TestMap::Iterator(map).Next(); 33 entry = TestMap::Iterator(map).Next();
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 EXPECT_STREQ("there", map.GetValueForKey("hi")); 286 EXPECT_STREQ("there", map.GetValueForKey("hi"));
287 287
288 ASSERT_DEATH(map.GetValueForKey(NULL), "key"); 288 ASSERT_DEATH(map.GetValueForKey(NULL), "key");
289 map.RemoveKey("hi"); 289 map.RemoveKey("hi");
290 EXPECT_EQ(0u, map.GetCount()); 290 EXPECT_EQ(0u, map.GetCount());
291 } 291 }
292 292
293 #endif 293 #endif
294 294
295 } // namespace 295 } // namespace
296 } // namespace test
297 } // namespace crashpad
OLDNEW
« no previous file with comments | « client/capture_context_mac_test.cc ('k') | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698