Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: build/android/pack_arm_relocations.gypi

Issue 635863002: Name packed relocations section appropriately for arm64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update for review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/pack_arm_relocations.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file is meant to be included into an action to provide a rule that 5 # This file is meant to be included into an action to provide a rule that
6 # packs ARM relative relocations in Release builds of native libraries. 6 # packs ARM relative relocations in Release builds of native libraries.
7 # 7 #
8 # To use this, create a gyp target with the following form: 8 # To use this, create a gyp target with the following form:
9 # { 9 # {
10 # 'action_name': 'pack_arm_relocations', 10 # 'action_name': 'pack_arm_relocations',
11 # 'actions': [ 11 # 'actions': [
12 # 'variables': { 12 # 'variables': {
13 # 'enable_packing': 'pack relocations if 1, plain file copy if 0' 13 # 'enable_packing': 'pack relocations if 1, plain file copy if 0'
14 # 'exclude_packing_list': 'names of libraries explicitly not packed', 14 # 'exclude_packing_list': 'names of libraries explicitly not packed',
15 # 'ordered_libraries_file': 'file generated by write_ordered_libraries' 15 # 'ordered_libraries_file': 'file generated by write_ordered_libraries'
16 # 'input_paths': 'files to be added to the list of inputs' 16 # 'input_paths': 'files to be added to the list of inputs'
17 # 'stamp': 'file to touch when the action is complete' 17 # 'stamp': 'file to touch when the action is complete'
18 # 'stripped_libraries_dir': 'directory holding stripped libraries', 18 # 'stripped_libraries_dir': 'directory holding stripped libraries',
19 # 'packed_libraries_dir': 'directory holding packed libraries', 19 # 'packed_libraries_dir': 'directory holding packed libraries',
20 # 'includes': [ '../../build/android/pack_arm_relocations.gypi' ], 20 # 'includes': [ '../../build/android/pack_arm_relocations.gypi' ],
21 # ], 21 # ],
22 # }, 22 # },
23 # 23 #
24 24
25 { 25 {
26 'variables': { 26 'variables': {
27 'input_paths': [], 27 'input_paths': [],
28 'conditions': [
29 ['target_arch == "arm64"', {
30 'has_relocations_with_addends': 1,
31 }, {
32 'has_relocations_with_addends': 0,
33 }],
34 ],
28 }, 35 },
29 'inputs': [ 36 'inputs': [
30 '<(DEPTH)/build/android/gyp/util/build_utils.py', 37 '<(DEPTH)/build/android/gyp/util/build_utils.py',
31 '<(DEPTH)/build/android/gyp/pack_arm_relocations.py', 38 '<(DEPTH)/build/android/gyp/pack_arm_relocations.py',
32 '<(ordered_libraries_file)', 39 '<(ordered_libraries_file)',
33 '>@(input_paths)', 40 '>@(input_paths)',
34 ], 41 ],
35 'outputs': [ 42 'outputs': [
36 '<(stamp)', 43 '<(stamp)',
37 ], 44 ],
38 'conditions': [ 45 'conditions': [
39 ['enable_packing == 1', { 46 ['enable_packing == 1', {
40 'message': 'Packing ARM relative relocations for <(_target_name)', 47 'message': 'Packing ARM relative relocations for <(_target_name)',
41 'dependencies': [ 48 'dependencies': [
42 '<(DEPTH)/tools/relocation_packer/relocation_packer.gyp:relocation_packe r#host', 49 '<(DEPTH)/tools/relocation_packer/relocation_packer.gyp:relocation_packe r#host',
43 ], 50 ],
44 'inputs': [ 51 'inputs': [
45 '<(PRODUCT_DIR)/relocation_packer', 52 '<(PRODUCT_DIR)/relocation_packer',
46 ], 53 ],
47 'action': [ 54 'action': [
48 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py', 55 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py',
49 '--configuration-name=<(CONFIGURATION_NAME)', 56 '--configuration-name=<(CONFIGURATION_NAME)',
50 '--enable-packing=1', 57 '--enable-packing=1',
58 '--has-relocations-with-addends=<(has_relocations_with_addends)',
51 '--exclude-packing-list=<@(exclude_packing_list)', 59 '--exclude-packing-list=<@(exclude_packing_list)',
52 '--android-pack-relocations=<(PRODUCT_DIR)/relocation_packer', 60 '--android-pack-relocations=<(PRODUCT_DIR)/relocation_packer',
53 '--android-objcopy=<(android_objcopy)', 61 '--android-objcopy=<(android_objcopy)',
54 '--stripped-libraries-dir=<(stripped_libraries_dir)', 62 '--stripped-libraries-dir=<(stripped_libraries_dir)',
55 '--packed-libraries-dir=<(packed_libraries_dir)', 63 '--packed-libraries-dir=<(packed_libraries_dir)',
56 '--libraries=@FileArg(<(ordered_libraries_file):libraries)', 64 '--libraries=@FileArg(<(ordered_libraries_file):libraries)',
57 '--stamp=<(stamp)', 65 '--stamp=<(stamp)',
58 ], 66 ],
59 }, { 67 }, {
60 'message': 'Copying libraries (no relocation packing) for <(_target_name)' , 68 'message': 'Copying libraries (no relocation packing) for <(_target_name)' ,
61 'action': [ 69 'action': [
62 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py', 70 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py',
63 '--configuration-name=<(CONFIGURATION_NAME)', 71 '--configuration-name=<(CONFIGURATION_NAME)',
64 '--enable-packing=0', 72 '--enable-packing=0',
65 '--stripped-libraries-dir=<(stripped_libraries_dir)', 73 '--stripped-libraries-dir=<(stripped_libraries_dir)',
66 '--packed-libraries-dir=<(packed_libraries_dir)', 74 '--packed-libraries-dir=<(packed_libraries_dir)',
67 '--libraries=@FileArg(<(ordered_libraries_file):libraries)', 75 '--libraries=@FileArg(<(ordered_libraries_file):libraries)',
68 '--stamp=<(stamp)', 76 '--stamp=<(stamp)',
69 ], 77 ],
70 }], 78 }],
71 ['component == "shared_library"', { 79 ['component == "shared_library"', {
72 # Add a fake output to force the build to always re-run this step. This 80 # Add a fake output to force the build to always re-run this step. This
73 # is required because the real inputs are not known at gyp-time and 81 # is required because the real inputs are not known at gyp-time and
74 # changing base.so may not trigger changes to dependent libraries. 82 # changing base.so may not trigger changes to dependent libraries.
75 'outputs': [ '<(stamp).fake' ] 83 'outputs': [ '<(stamp).fake' ]
76 }], 84 }],
77 ], 85 ],
78 } 86 }
OLDNEW
« no previous file with comments | « build/android/gyp/pack_arm_relocations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698