Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 635863002: Name packed relocations section appropriately for arm64. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Name packed relocations section appropriately for arm64. Arm uses .rel.dyn, and arm64 .rela.dyn. For consistency, name the packed relocations section as '.android.rela.dyn' for arm64, and leave '.android.rel.dyn' for arm32. [ No semantic effect, since packing and unpacking tools treat both section names identically, and use the signature at the start of section data to indicate content type. ] BUG=385553 Committed: https://crrev.com/1ddabff1f7612387b7578d3855cb5ba9729de9f2 Cr-Commit-Position: refs/heads/master@{#298515}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update for review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M build/android/gyp/pack_arm_relocations.py View 1 5 chunks +18 lines, -6 lines 0 comments Download
M build/android/pack_arm_relocations.gypi View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-07 13:41:37 UTC) #2
rmcilroy
https://codereview.chromium.org/635863002/diff/1/build/android/gyp/pack_arm_relocations.py File build/android/gyp/pack_arm_relocations.py (right): https://codereview.chromium.org/635863002/diff/1/build/android/gyp/pack_arm_relocations.py#newcode48 build/android/gyp/pack_arm_relocations.py:48: new_section = '.android.rel.dyn' This seems a bit hacky to ...
6 years, 2 months ago (2014-10-07 14:02:39 UTC) #3
simonb (inactive)
https://codereview.chromium.org/635863002/diff/1/build/android/gyp/pack_arm_relocations.py File build/android/gyp/pack_arm_relocations.py (right): https://codereview.chromium.org/635863002/diff/1/build/android/gyp/pack_arm_relocations.py#newcode48 build/android/gyp/pack_arm_relocations.py:48: new_section = '.android.rel.dyn' On 2014/10/07 14:02:39, rmcilroy wrote: > ...
6 years, 2 months ago (2014-10-07 15:34:20 UTC) #4
rmcilroy
lgtm, thanks.
6 years, 2 months ago (2014-10-07 15:58:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635863002/20001
6 years, 2 months ago (2014-10-07 16:03:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 875cafa91fccb74ebaac5979e80dd3f8692de158
6 years, 2 months ago (2014-10-07 17:30:44 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 17:31:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ddabff1f7612387b7578d3855cb5ba9729de9f2
Cr-Commit-Position: refs/heads/master@{#298515}

Powered by Google App Engine
This is Rietveld 408576698