Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 635813002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules/webmidi (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules/webmidi This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M Source/modules/webmidi/MIDIAccess.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessor.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webmidi/MIDIClientMock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIConnectionEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIInput.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIMessageEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIPortMap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:11:22 UTC) #2
MRV
On 2014/10/07 12:11:22, MRV wrote: > PTAL Dear mr.jochen, please review my patch.
6 years, 2 months ago (2014-10-08 00:38:35 UTC) #4
Mike West
rs lgtm, but you'll need a Web MIDI OWNER: how about toyoshim@?
6 years, 2 months ago (2014-10-08 05:21:11 UTC) #6
MRV
On 2014/10/08 05:21:11, Mike West wrote: > rs lgtm, but you'll need a Web MIDI ...
6 years, 2 months ago (2014-10-08 05:33:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635813002/1
6 years, 2 months ago (2014-10-08 05:33:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/16950)
6 years, 2 months ago (2014-10-08 05:39:44 UTC) #11
Takashi Toyoshima
That's nice. Thank you for working on webmidi. LGTM.
6 years, 2 months ago (2014-10-08 06:59:42 UTC) #12
MRV
On 2014/10/08 06:59:42, Takashi Toyoshima (chromium) wrote: > That's nice. Thank you for working on ...
6 years, 2 months ago (2014-10-08 07:17:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635813002/1
6 years, 2 months ago (2014-10-08 07:17:30 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 07:21:26 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183392

Powered by Google App Engine
This is Rietveld 408576698