Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3919)

Unified Diff: cc/resources/zero_copy_raster_worker_pool.cc

Issue 635733004: cc: Add ScopedWriteLock classes for raster to GpuMemoryBuffer or using Ganesh. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/resource_provider_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/zero_copy_raster_worker_pool.cc
diff --git a/cc/resources/zero_copy_raster_worker_pool.cc b/cc/resources/zero_copy_raster_worker_pool.cc
index 8d98eaf0a700b6466f7f93916a455e3ceb120163..0d9c21afb1253c6eb8e0efaafff006540facaf58 100644
--- a/cc/resources/zero_copy_raster_worker_pool.cc
+++ b/cc/resources/zero_copy_raster_worker_pool.cc
@@ -21,27 +21,21 @@ class RasterBufferImpl : public RasterBuffer {
public:
RasterBufferImpl(ResourceProvider* resource_provider,
const Resource* resource)
- : resource_provider_(resource_provider),
+ : lock_(resource_provider, resource->id()),
resource_(resource),
- stride_(0),
- buffer_(resource_provider->MapImage(resource->id(), &stride_)) {}
-
- virtual ~RasterBufferImpl() {
- resource_provider_->UnmapImage(resource_->id());
-
- // This RasterBuffer implementation provides direct access to the memory
- // used by the GPU. Read lock fences are required to ensure that we're not
- // trying to map a resource that is currently in-use by the GPU.
- resource_provider_->EnableReadLockFences(resource_->id());
- }
+ buffer_(NULL) {}
// Overridden from RasterBuffer:
virtual skia::RefPtr<SkCanvas> AcquireSkCanvas() override {
+ buffer_ = lock_.gpu_memory_buffer();
if (!buffer_)
return skia::AdoptRef(SkCreateNullCanvas());
- RasterWorkerPool::AcquireBitmapForBuffer(
- &bitmap_, buffer_, resource_->format(), resource_->size(), stride_);
+ RasterWorkerPool::AcquireBitmapForBuffer(&bitmap_,
+ buffer_,
+ resource_->format(),
+ resource_->size(),
+ lock_.stride());
return skia::AdoptRef(new SkCanvas(bitmap_));
}
virtual void ReleaseSkCanvas(const skia::RefPtr<SkCanvas>& canvas) override {
@@ -53,10 +47,9 @@ class RasterBufferImpl : public RasterBuffer {
}
private:
- ResourceProvider* resource_provider_;
+ ResourceProvider::ScopedWriteLockGpuMemoryBuffer lock_;
const Resource* resource_;
- int stride_;
- uint8_t* buffer_;
+ void* buffer_;
SkBitmap bitmap_;
DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
@@ -190,10 +183,6 @@ void ZeroCopyRasterWorkerPool::CheckForCompletedTasks() {
scoped_ptr<RasterBuffer> ZeroCopyRasterWorkerPool::AcquireBufferForRaster(
const Resource* resource) {
- // RasterBuffer implementation depends on an image having been acquired for
- // the resource.
- resource_provider_->AcquireImage(resource->id());
-
return make_scoped_ptr<RasterBuffer>(
new RasterBufferImpl(resource_provider_, resource));
}
« no previous file with comments | « cc/resources/resource_provider_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698