Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

Issue 635733003: [DevTools] Migrate DevToolsTracingHandler to generated handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py
diff --git a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
index aa7c507a1ba482d87c51834eb32f78b8d4403c27..9798a5cd293b25134491c040088df01b157c7507 100755
--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
@@ -120,8 +120,7 @@ tmpl_client = string.Template("""\
namespace ${domain} {
class Client : public DevToolsProtocolClient {
public:
- Client(const EventCallback& event_callback,
- const ResponseCallback& response_callback);
+ Client(const RawMessageCallback& raw_message_callback);
virtual ~Client();
${methods}\
@@ -246,9 +245,7 @@ tmpl_register = string.Template("""\
tmpl_init_client = string.Template("""\
${domain}_handler_->SetClient(make_scoped_ptr(
new devtools::${domain}::Client(
- base::Bind(&DevToolsProtocolHandlerImpl::SendNotification,
- base::Unretained(this)),
- base::Bind(&DevToolsProtocolHandlerImpl::SendAsyncResponse,
+ base::Bind(&DevToolsProtocolHandlerImpl::SendRawMessage,
base::Unretained(this)))));
""")
@@ -358,9 +355,8 @@ void ${declared_name}::set_${param}(
tmpl_client_impl = string.Template("""\
namespace ${domain} {
-Client::Client(const EventCallback& event_callback,
- const ResponseCallback& response_callback)
- : DevToolsProtocolClient(event_callback, response_callback) {
+Client::Client(const RawMessageCallback& raw_message_callback)
+ : DevToolsProtocolClient(raw_message_callback) {
}
Client::~Client() {

Powered by Google App Engine
This is Rietveld 408576698