Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_client.cc

Issue 635733003: [DevTools] Migrate DevToolsTracingHandler to generated handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_client.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_client.cc b/content/browser/devtools/protocol/devtools_protocol_client.cc
index a0d9547d1bc675750f337a96cac055b64245b99e..a34189e0efc17f98725ceca4d6796a80226c3dde 100644
--- a/content/browser/devtools/protocol/devtools_protocol_client.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_client.cc
@@ -7,10 +7,8 @@
namespace content {
DevToolsProtocolClient::DevToolsProtocolClient(
- const EventCallback& event_callback,
- const ResponseCallback& response_callback)
- : event_callback_(event_callback),
- response_callback_(response_callback) {
+ const RawMessageCallback& raw_message_callback)
+ : raw_message_callback_(raw_message_callback) {
}
DevToolsProtocolClient::~DevToolsProtocolClient() {
@@ -18,12 +16,18 @@ DevToolsProtocolClient::~DevToolsProtocolClient() {
void DevToolsProtocolClient::SendNotification(const std::string& method,
base::DictionaryValue* params) {
- event_callback_.Run(method, params);
+ scoped_refptr<DevToolsProtocol::Notification> notification =
+ new DevToolsProtocol::Notification(method, params);
+ SendRawMessage(notification->Serialize());
}
void DevToolsProtocolClient::SendAsyncResponse(
scoped_refptr<DevToolsProtocol::Response> response) {
- response_callback_.Run(response);
+ SendRawMessage(response->Serialize());
+}
+
+void DevToolsProtocolClient::SendRawMessage(const std::string& message) {
+ raw_message_callback_.Run(message);
}
void DevToolsProtocolClient::SendInvalidParamsResponse(

Powered by Google App Engine
This is Rietveld 408576698